You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/10/31 01:16:34 UTC
svn commit: r1537353 - in /commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl: TestGenericKeyedObjectPool.java TestGenericObjectPool.java

Author: sebb
Date: Thu Oct 31 00:16:34 2013
New Revision: 1537353

URL: http://svn.apache.org/r1537353
Log:
Avoid data hiding

Modified:
    commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
    commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java

Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java?rev=1537353&r1=1537352&r2=1537353&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java Thu Oct 31 00:16:34 2013
@@ -69,8 +69,8 @@ public class TestGenericKeyedObjectPool 
     }
 
     @Override
-    protected KeyedObjectPool<Object,Object> makeEmptyPool(KeyedPooledObjectFactory<Object,Object> factory) {
-        return new GenericKeyedObjectPool<Object,Object>(factory);
+    protected KeyedObjectPool<Object,Object> makeEmptyPool(KeyedPooledObjectFactory<Object,Object> fac) {
+        return new GenericKeyedObjectPool<Object,Object>(fac);
     }
 
     @Override
@@ -505,10 +505,10 @@ public class TestGenericKeyedObjectPool 
      * <iterations> borrow-return cycles with random delay times <= delay
      * in between.
      */
-    public <T> void runTestThreads(int numThreads, int iterations, int delay, GenericKeyedObjectPool<String,T> pool) {
+    public <T> void runTestThreads(int numThreads, int iterations, int delay, GenericKeyedObjectPool<String,T> gkopPool) {
         ArrayList<TestThread<T>> threads = new ArrayList<TestThread<T>>();
         for(int i=0;i<numThreads;i++) {
-            TestThread<T> testThread = new TestThread<T>(pool, iterations, delay);
+            TestThread<T> testThread = new TestThread<T>(gkopPool, iterations, delay);
             threads.add(testThread);
             Thread t = new Thread(testThread);
             t.start();

Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java?rev=1537353&r1=1537352&r2=1537353&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java Thu Oct 31 00:16:34 2013
@@ -63,8 +63,8 @@ public class TestGenericObjectPool exten
 
     @Override
     protected ObjectPool<Object> makeEmptyPool(
-            final PooledObjectFactory<Object> factory) {
-        return new GenericObjectPool<Object>(factory);
+            final PooledObjectFactory<Object> fac) {
+        return new GenericObjectPool<Object>(fac);
     }
 
     @Override