You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sashapolo (via GitHub)" <gi...@apache.org> on 2023/09/01 12:56:52 UTC

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2531: IGNITE-20328 Cleanup in BaseIgniteAbstractTest

sashapolo commented on code in PR #2531:
URL: https://github.com/apache/ignite-3/pull/2531#discussion_r1312993420


##########
modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/BaseIgniteAbstractTest.java:
##########
@@ -39,67 +40,55 @@
 @ExtendWith(SystemPropertiesExtension.class)
 public abstract class BaseIgniteAbstractTest {
     /** Logger. */
-    protected static IgniteLogger log;
+    protected final IgniteLogger log = Loggers.forClass(getClass());
 
     /** Test start time in milliseconds. */
     private long testStartMs;
 
-    static {
-        /* Init test env. */
-        S.setSensitiveDataLoggingPolicySupplier(() ->
-                SensitiveDataLoggingPolicy.valueOf(getString(IGNITE_SENSITIVE_DATA_LOGGING, "hash").toUpperCase()));
+    @BeforeAll
+    static void setLoggingPolicy() {
+        S.setSensitiveDataLoggingPolicySupplier(() -> {

Review Comment:
   I don't know, isn't it what we did before?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org