You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/06 20:17:02 UTC
[GitHub] [arrow] ianmcook opened a new pull request #10666: ARROW-13216: [R] Type checks test fails with rtools35
ianmcook opened a new pull request #10666:
URL: https://github.com/apache/arrow/pull/10666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10666: ARROW-13216: [R] Type checks test fails with rtools35
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10666:
URL: https://github.com/apache/arrow/pull/10666#issuecomment-875054258
Revision: ca0275ff93259f275e866e2d1e4314f74841bed4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-575](https://github.com/ursacomputing/crossbow/branches/all?query=actions-575)
|Task|Status|
|----|------|
|test-r-rtools-35|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-575-github-test-r-rtools-35)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook closed pull request #10666: ARROW-13216: [R] Type checks test fails with rtools35
Posted by GitBox <gi...@apache.org>.
ianmcook closed pull request #10666:
URL: https://github.com/apache/arrow/pull/10666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10666: ARROW-13216: [R] Type checks test fails with rtools35
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10666:
URL: https://github.com/apache/arrow/pull/10666#issuecomment-875053035
https://issues.apache.org/jira/browse/ARROW-13216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10666: ARROW-13216: [R] Type checks test fails with rtools35
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10666:
URL: https://github.com/apache/arrow/pull/10666#issuecomment-875074055
@github-actions crossbow submit test-r-rtools-35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10666: ARROW-13216: [R] Type checks test fails with rtools35
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10666:
URL: https://github.com/apache/arrow/pull/10666#issuecomment-875053748
@github-actions crossbow submit test-r-rtools-35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10666: ARROW-13216: [R] Type checks test fails with rtools35
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10666:
URL: https://github.com/apache/arrow/pull/10666#discussion_r664866019
##########
File path: r/tests/testthat/test-dplyr.R
##########
@@ -815,7 +815,18 @@ test_that("type checks on expressions", {
a = is.character(as.character(int)),
b = is.integer(as.character(int)),
c = is.integer(int + int),
- d = is.double(int + dbl),
+ d = is.double(int + dbl)
Review comment:
If you wanted to confirm that `is.logical` works you could do:
```
e = is.logical(chr %in% c("d", "e", "f"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10666: ARROW-13216: [R] Type checks test fails with rtools35
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10666:
URL: https://github.com/apache/arrow/pull/10666#issuecomment-875074597
Revision: dd8c98c8bd010c025e895615cc6f325a627217fd
Submitted crossbow builds: [ursacomputing/crossbow @ actions-576](https://github.com/ursacomputing/crossbow/branches/all?query=actions-576)
|Task|Status|
|----|------|
|test-r-rtools-35|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-576-github-test-r-rtools-35)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10666: ARROW-13216: [R] Type checks test fails with rtools35
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10666:
URL: https://github.com/apache/arrow/pull/10666#discussion_r664869674
##########
File path: r/tests/testthat/test-dplyr.R
##########
@@ -815,7 +815,18 @@ test_that("type checks on expressions", {
a = is.character(as.character(int)),
b = is.integer(as.character(int)),
c = is.integer(int + int),
- d = is.double(int + dbl),
+ d = is.double(int + dbl)
Review comment:
Sounds good. I'll keep it simpler and use a numeric inequality instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org