You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <ji...@apache.org> on 2008/08/08 17:13:44 UTC
[jira] Created: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Add Apache 2.0 license headers to a number of files
---------------------------------------------------
Key: DERBY-3827
URL: https://issues.apache.org/jira/browse/DERBY-3827
Project: Derby
Issue Type: Task
Affects Versions: 10.4.2.0, 10.5.0.0
Reporter: Rick Hillegas
Fix For: 10.4.2.0, 10.5.0.0
Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-3827:
---------------------------------
Attachment: missingLicense.out
Attaching missingLicense.out. This is the output of a script which lists out files which need license headers.
> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
> Key: DERBY-3827
> URL: https://issues.apache.org/jira/browse/DERBY-3827
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.4.2.0, 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Fix For: 10.4.2.0, 10.5.0.0
>
> Attachments: missingLicense.out
>
>
> Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-3827:
---------------------------------
Attachment: derby-3827-01-ab-withReadmeFiles.diff
Attaching derby-3827-01-ab-withReadmeFiles.diff. This is identical to the previous patch except that it adds license headers to readme files and to an additional properties file which wasn't covered in the first patch. I asked legal-discuss whether I should put license headers on readme files. The response was mixed. Some people thought it was necessary. Other people thought it was overkill. See the thread titled "Do README files need Apache license headers?" at http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200808.mbox/browser I have decided to err on the side of caution.
Touches the following files:
M java/demo/vtis/sql/demoFileVtis.sql
M java/demo/vtis/sql/demoForeignDbmsVtis.sql
M java/demo/vtis/README
M java/demo/scores/README
M java/demo/localcal/README
M java/demo/README.txt
M java/drda/org/apache/derby/drda/server.policy
M java/drda/org/apache/derby/drda/template.policy
M java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest.policy
M java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest1.policy
M java/testing/org/apache/derbyTesting/unitTests/junit/AssertFailureTest.policy
M java/testing/org/apache/derbyTesting/unitTests/junit/AssertFailureTest1.policy
M java/testing/org/apache/derbyTesting/functionTests/tests/unit/readme
M java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/README.runningTests
M java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/README.testReplication
M java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/README.testproperties
M java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/README.framework
M java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/replicationtest.properties
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/XAJNDITest.java
M java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/NetworkServerControlClientCommandTest.java
M java/testing/org/apache/derbyTesting/functionTests/util/useprocessfalse.policy
M java/testing/org/apache/derbyTesting/functionTests/util/SQLStateConstants.java
M java/testing/org/apache/derbyTesting/functionTests/util/nwsvr.policy
M java/client/org/apache/derby/client/am/stmtcache/package.html
M java/client/org/apache/derby/client/am/StatementCacheInteractor.java
M plugins/eclipse/org.apache.derby.ui/.classpath
M plugins/eclipse/org.apache.derby.ui/.project
M plugins/eclipse/org.apache.derby.plugin.doc/.project
M README
M tools/ide/netbeans/6.0/nbproject/project.xml
M tools/ide/netbeans/5.5/nbproject/project.xml
M tools/ide/netbeans/README.txt
M tools/ant/properties/packaging.tmpl
M tools/ant/properties/release.properties
M tools/javadoc/publishedapi_jdbc3.ant
M tools/javadoc/publishedapi_jdbc4.ant
M tools/javadoc/derbydocs_jdbc4_exclusions.ant
M tools/javadoc/publishedapi.ant
M tools/javadoc/derbydocs_exclusions.ant
M tools/l10n/README
M tools/testing/i18nTestGenerator/README
M tools/testing/reporting/scripts/README.1
M tools/testing/reporting/scripts/README.2
M tools/testing/reporting/scripts/TODO
> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
> Key: DERBY-3827
> URL: https://issues.apache.org/jira/browse/DERBY-3827
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.4.2.0, 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Fix For: 10.4.2.0, 10.5.0.0
>
> Attachments: derby-3827-01-aa-filesExceptReadmes.diff, derby-3827-01-ab-withReadmeFiles.diff, missingLicense.out
>
>
> Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas reassigned DERBY-3827:
------------------------------------
Assignee: Rick Hillegas
> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
> Key: DERBY-3827
> URL: https://issues.apache.org/jira/browse/DERBY-3827
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.4.2.0, 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Fix For: 10.4.2.0, 10.5.0.0
>
>
> Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621506#action_12621506 ]
Rick Hillegas commented on DERBY-3827:
--------------------------------------
Ported 684809 from trunk to branch at subversion revision 684821.
> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
> Key: DERBY-3827
> URL: https://issues.apache.org/jira/browse/DERBY-3827
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.4.2.0, 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Fix For: 10.4.2.0, 10.5.0.0
>
> Attachments: derby-3827-01-aa-filesExceptReadmes.diff, derby-3827-01-ab-withReadmeFiles.diff, missingLicense.out
>
>
> Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas closed DERBY-3827.
--------------------------------
Resolution: Fixed
> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
> Key: DERBY-3827
> URL: https://issues.apache.org/jira/browse/DERBY-3827
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.4.2.0, 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Fix For: 10.4.2.0, 10.5.0.0
>
> Attachments: derby-3827-01-aa-filesExceptReadmes.diff, derby-3827-01-ab-withReadmeFiles.diff, missingLicense.out
>
>
> Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624136#action_12624136 ]
Rick Hillegas commented on DERBY-3827:
--------------------------------------
It was noted on derby-dev that the jars for the database classloader tests contain java source files which don't have Apache headers: http://www.nabble.com/Where-is-the-source-for-dcl-jars--td18987689.html#a18987689 I added headers to the java sources in those jars and then re-jarred them. The DatabaseClassLoadingTest then failed because one of the jar files was supposed to be signed. This signing instructions can be found in the header comment on DatabseClassLoadingTest.testSignedJar(). I then signed that jar using those instructions. This eliminated one of the errors in DatabaseClassLoadingTest. However, a second error persists:
There was 1 failure:
1) testHackedJarReplacedClass(org.apache.derbyTesting.functionTests.tests.lang.DatabaseClassLoadingTest)junit.framework.AssertionFailedError: procedure call worked on hacked jar
at org.apache.derbyTesting.functionTests.tests.lang.DatabaseClassLoadingTest.testHackedJarReplacedClass(DatabaseClassLoadingTest.java:533)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:104)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
at junit.extensions.TestSetup.run(TestSetup.java:25)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
at junit.extensions.TestSetup.run(TestSetup.java:25)
at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
FAILURES!!!
Tests run: 25, Failures: 1, Errors: 0
Maybe someone who is an expert on these tests can figure out how to fix this problem.
> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
> Key: DERBY-3827
> URL: https://issues.apache.org/jira/browse/DERBY-3827
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.4.2.0, 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Fix For: 10.4.2.0, 10.5.0.0
>
> Attachments: derby-3827-01-aa-filesExceptReadmes.diff, derby-3827-01-ab-withReadmeFiles.diff, missingLicense.out
>
>
> Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620954#action_12620954 ]
Rick Hillegas commented on DERBY-3827:
--------------------------------------
Do README and TODO files need an Apache license header? There are a number of these:
/Users/rh161140/derby/mainline/trunk/java/demo/README.txt
/Users/rh161140/derby/mainline/trunk/java/demo/localcal/README
/Users/rh161140/derby/mainline/trunk/java/demo/scores/README
/Users/rh161140/derby/mainline/trunk/java/demo/vtis/README /Users/rh161140/derby/mainline/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/README.framework /Users/rh161140/derby/mainline/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/README.runningTests /Users/rh161140/derby/mainline/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/README.testReplication /Users/rh161140/derby/mainline/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/README.testproperties /Users/rh161140/derby/mainline/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/replicationTests/replicationtest.properties /Users/rh161140/derby/mainline/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/unit/readme
/Users/rh161140/derby/mainline/trunk/tools/ide/netbeans/README.txt
/Users/rh161140/derby/mainline/trunk/tools/l10n/README
/Users/rh161140/derby/mainline/trunk/tools/testing/i18nTestGenerator/README
/Users/rh161140/derby/mainline/trunk/tools/testing/reporting/scripts/README.1
/Users/rh161140/derby/mainline/trunk/tools/testing/reporting/scripts/README.2
/Users/rh161140/derby/mainline/trunk/tools/testing/reporting/scripts/TODO
> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
> Key: DERBY-3827
> URL: https://issues.apache.org/jira/browse/DERBY-3827
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.4.2.0, 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Fix For: 10.4.2.0, 10.5.0.0
>
> Attachments: missingLicense.out
>
>
> Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-3827:
---------------------------------
Attachment: derby-3827-01-aa-filesExceptReadmes.diff
Attaching derby-3827-01-aa-filesExceptReadmes.diff. This patch adds license headers to the files on my list except for the READMEs. Touches the following files:
M java/demo/vtis/sql/demoFileVtis.sql
M java/demo/vtis/sql/demoForeignDbmsVtis.sql
M java/drda/org/apache/derby/drda/server.policy
M java/drda/org/apache/derby/drda/template.policy
M java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest.policy
M java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest1.policy
M java/testing/org/apache/derbyTesting/unitTests/junit/AssertFailureTest.policy
M java/testing/org/apache/derbyTesting/unitTests/junit/AssertFailureTest1.policy
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/XAJNDITest.java
M java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/NetworkServerControlClientCommandTest.java
M java/testing/org/apache/derbyTesting/functionTests/util/useprocessfalse.policy
M java/testing/org/apache/derbyTesting/functionTests/util/SQLStateConstants.java
M java/testing/org/apache/derbyTesting/functionTests/util/nwsvr.policy
M java/client/org/apache/derby/client/am/stmtcache/package.html
M java/client/org/apache/derby/client/am/StatementCacheInteractor.java
M plugins/eclipse/org.apache.derby.ui/.classpath
M plugins/eclipse/org.apache.derby.ui/.project
M plugins/eclipse/org.apache.derby.plugin.doc/.project
M tools/ide/netbeans/6.0/nbproject/project.xml
M tools/ide/netbeans/5.5/nbproject/project.xml
M tools/ant/properties/packaging.tmpl
M tools/ant/properties/release.properties
M tools/javadoc/publishedapi_jdbc3.ant
M tools/javadoc/publishedapi_jdbc4.ant
M tools/javadoc/derbydocs_jdbc4_exclusions.ant
M tools/javadoc/publishedapi.ant
M tools/javadoc/derbydocs_exclusions.ant
> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
> Key: DERBY-3827
> URL: https://issues.apache.org/jira/browse/DERBY-3827
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.4.2.0, 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Fix For: 10.4.2.0, 10.5.0.0
>
> Attachments: derby-3827-01-aa-filesExceptReadmes.diff, missingLicense.out
>
>
> Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3827) Add Apache 2.0 license headers to a
number of files
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621500#action_12621500 ]
Rick Hillegas commented on DERBY-3827:
--------------------------------------
Committed derby-3827-01-ab-withReadmeFiles.diff at subversion revision 684809.
> Add Apache 2.0 license headers to a number of files
> ---------------------------------------------------
>
> Key: DERBY-3827
> URL: https://issues.apache.org/jira/browse/DERBY-3827
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.4.2.0, 10.5.0.0
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Fix For: 10.4.2.0, 10.5.0.0
>
> Attachments: derby-3827-01-aa-filesExceptReadmes.diff, derby-3827-01-ab-withReadmeFiles.diff, missingLicense.out
>
>
> Several source files are missing license headers. I will attach a list of files which need headers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.