You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/10/11 19:43:03 UTC
[GitHub] PircDef commented on a change in pull request #692: Remove key
provider from crypto
PircDef commented on a change in pull request #692: Remove key provider from crypto
URL: https://github.com/apache/accumulo/pull/692#discussion_r224580141
##########
File path: core/src/main/java/org/apache/accumulo/core/security/crypto/impl/AESCryptoService.java
##########
@@ -72,12 +72,11 @@
@Override
public void init(Map<String,String> conf) throws CryptoException {
- String keyLocation = conf.get("instance.crypto.opts.key.location");
- String keyMgr = conf.get("instance.crypto.opts.key.provider");
+ String keyLocation = conf.get("instance.crypto.opts.key.uri");
+ // get key from URI for now, keyMgr framework could be expanded on in the future
+ String keyMgr = "uri";
Objects.requireNonNull(keyLocation,
Review comment:
If we're going to move the option to a properties value, such as "instance.crypto.opts.key.uri", we should probably also move the Objects.requireNonNull() to this.encryptingKek after the switch statement. That way as keyMgr's are added in the future, only the result is checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services