You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/06 09:16:09 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3028: Update parquet to depend on arrow subcrates
tustvold opened a new pull request, #3028:
URL: https://github.com/apache/arrow-rs/pull/3028
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #2594
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018634151
##########
parquet/Cargo.toml:
##########
@@ -70,9 +78,9 @@ all-features = true
[features]
default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"]
# Enable arrow reader/writer APIs
-arrow = ["dep:arrow", "base64"]
+arrow = ["base64", "arrow-array", "arrow-buffer", "arrow-cast", "arrow-data", "arrow-schema", "arrow-select", "arrow-ipc"]
Review Comment:
Nvm, I thought if this `arrow` is unnecessary and we can just have these "base64" features. But I saw you use `arrow` as a whole feature in many places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018636949
##########
parquet/src/errors.rs:
##########
@@ -19,8 +19,8 @@
use std::{cell, io, result, str};
-#[cfg(any(feature = "arrow", test))]
Review Comment:
You mean removing `test`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018667345
##########
parquet/src/errors.rs:
##########
@@ -19,8 +19,8 @@
use std::{cell, io, result, str};
-#[cfg(any(feature = "arrow", test))]
Review Comment:
Did you do `cargo test --no-default-features`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#issuecomment-1310923048
Benchmark runs are scheduled for baseline = 132152cb8db5085163ee0f21d24fc867716ba6d5 and contender = 4dd7fea13dd2ac62f179fc7fc245037e7036afc9. 4dd7fea13dd2ac62f179fc7fc245037e7036afc9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4ba55e2fae1648c083668df6d6906b04...b0dcd5f847a34063928548cdea58fe3f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/867fc4c262364249ac14be6c37557820...585328fad2cc4f48b4dbaf89ec5d9455/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/705d231a57454802a4a9e16806f2e974...487b0951980449c890e3f691ca7e1035/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0afc023013774798ba43bd8c087a77e5...22408afac2094d509aec4db0454cec9d/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018613402
##########
parquet_derive/Cargo.toml:
##########
@@ -34,5 +34,5 @@ proc-macro = true
[dependencies]
proc-macro2 = { version = "1.0", default-features = false }
quote = { version = "1.0", default-features = false }
-syn = { version = "1.0", default-features = false }
-parquet = { path = "../parquet", version = "26.0.0" }
+syn = { version = "1.0", features = ["extra-traits"] }
+parquet = { path = "../parquet", version = "26.0.0", default-features = false }
Review Comment:
This is part drive-by-cleanup, part fix as it was relying on `multiversion` which is a transitive dependency of `arrow` to enable the `syn` features it requires. As parquet no longer depends on arrow, this caused issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018630325
##########
parquet/Cargo.toml:
##########
@@ -70,9 +78,9 @@ all-features = true
[features]
default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"]
# Enable arrow reader/writer APIs
-arrow = ["dep:arrow", "base64"]
+arrow = ["base64", "arrow-array", "arrow-buffer", "arrow-cast", "arrow-data", "arrow-schema", "arrow-select", "arrow-ipc"]
Review Comment:
Seems two lines can combined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018630698
##########
parquet/Cargo.toml:
##########
@@ -70,9 +78,9 @@ all-features = true
[features]
default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"]
# Enable arrow reader/writer APIs
-arrow = ["dep:arrow", "base64"]
+arrow = ["base64", "arrow-array", "arrow-buffer", "arrow-cast", "arrow-data", "arrow-schema", "arrow-select", "arrow-ipc"]
Review Comment:
What do you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018633121
##########
parquet/src/column/reader.rs:
##########
@@ -515,6 +515,7 @@ where
/// If the current page is fully decoded, this will NOT load the next page
/// into the buffer
#[inline]
+ #[cfg(feature = "arrow")]
pub(crate) fn peek_next(&mut self) -> Result<bool> {
Review Comment:
These changes were necessary to placate clippy as they aren't currently used by anything outside the arrow module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#issuecomment-1304759253
Need to revisit how we plumb in test utilities :cry:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018630325
##########
parquet/Cargo.toml:
##########
@@ -70,9 +78,9 @@ all-features = true
[features]
default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"]
# Enable arrow reader/writer APIs
-arrow = ["dep:arrow", "base64"]
+arrow = ["base64", "arrow-array", "arrow-buffer", "arrow-cast", "arrow-data", "arrow-schema", "arrow-select", "arrow-ipc"]
Review Comment:
Seems they can combined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018684775
##########
parquet/Cargo.toml:
##########
@@ -30,6 +30,14 @@ edition = "2021"
rust-version = "1.62"
[dependencies]
+arrow-array = { version = "26.0.0", path = "../arrow-array", default-features = false, optional = true }
Review Comment:
Maybe for some basic crates like arrow-buffer, arrow-data, arrow-schema, perhaps we can provide re-export (arrow-core?) for them.
Like you said, if this is just a special case, then it is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018613727
##########
parquet/src/errors.rs:
##########
@@ -19,8 +19,8 @@
use std::{cell, io, result, str};
-#[cfg(any(feature = "arrow", test))]
Review Comment:
This is necessary to avoid having to declare all the various subcrates as dev-dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018632796
##########
parquet/src/column/reader.rs:
##########
@@ -515,6 +515,7 @@ where
/// If the current page is fully decoded, this will NOT load the next page
/// into the buffer
#[inline]
+ #[cfg(feature = "arrow")]
pub(crate) fn peek_next(&mut self) -> Result<bool> {
Review Comment:
Hmm, is `peek_next` optional? It is used by some APIs like `skip_records`. If `arrow` is not enabled, what would happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018652785
##########
parquet/src/errors.rs:
##########
@@ -19,8 +19,8 @@
use std::{cell, io, result, str};
-#[cfg(any(feature = "arrow", test))]
Review Comment:
Hmm, I tried to restore only this line locally, and looks like the tests are okay to run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018671223
##########
parquet/src/errors.rs:
##########
@@ -19,8 +19,8 @@
use std::{cell, io, result, str};
-#[cfg(any(feature = "arrow", test))]
Review Comment:
Ah, yea, `arrow` is default feature. I didn't exclude it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1014794759
##########
parquet/Cargo.toml:
##########
@@ -30,6 +30,14 @@ edition = "2021"
rust-version = "1.62"
[dependencies]
+arrow-array = { version = "26.0.0", path = "../arrow-array", default-features = false, optional = true }
Review Comment:
It is somewhat unfortunate the number of these, perhaps we should provide re-exports to reduce this. On the flip side, parquet is a very complex crate and so perhaps it is just a bit special in needing all the things :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018637293
##########
parquet/src/errors.rs:
##########
@@ -19,8 +19,8 @@
use std::{cell, io, result, str};
-#[cfg(any(feature = "arrow", test))]
Review Comment:
Yeah, this only worked because arrow is a dev-dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3028: Update parquet to depend on arrow subcrates
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3028:
URL: https://github.com/apache/arrow-rs/pull/3028#discussion_r1018652785
##########
parquet/src/errors.rs:
##########
@@ -19,8 +19,8 @@
use std::{cell, io, result, str};
-#[cfg(any(feature = "arrow", test))]
Review Comment:
Hmm, I tried to restore only this line locally, and looks like the tests are still okay to run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org