You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/03/24 14:00:46 UTC
[GitHub] [arrow] westonpace opened a new pull request, #34726: GH-34564: [C++] Update code to compile with cython 3
westonpace opened a new pull request, #34726:
URL: https://github.com/apache/arrow/pull/34726
### Rationale for this change
Cython 3 has some breaking changes:
* `&&` is no longer supported
* `nogil` must appear at the end of the line
In addition we had to work around a bug: https://github.com/cython/cython/issues/5333
### What changes are included in this PR?
Minor changes to the cython code.
### Are these changes tested?
No, and they probably should be at some point. However, Cython 3 has not yet released and so it would be impractical to update our CI to run Cython 3 until that happens.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #34726: GH-34564: [Python][C++] Update code to compile with cython 3
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1483120757
> We could add a nightly build to catch Cython 3 issues?
Eventually, yes, I agree. At the moment Cython 3 hasn't released yet. The beta will not build due to known errors in the beta. I had to compile cython from the latest commit to get this to work. That's probably not worth maintaining so we can just wait and put the nightly build in (or update the existing builds) when Cython 3 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bdice commented on pull request #34726: GH-34564: [Python][C++] Update code to compile with cython 3
Posted by "bdice (via GitHub)" <gi...@apache.org>.
bdice commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1483247702
Thanks for this fix @westonpace!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34726: GH-34564: [C++] Update code to compile with cython 3
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1482851943
* Closes: #34564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34726: GH-34564: [Python][C++] Update code to compile with cython 3
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1483701554
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bd5c61a08f524318a6fe7f106bfbb083...d1b4473ddb8d4f7c82bba88d727d4515/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #34726: GH-34564: [Python][C++] Update code to compile with cython 3
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1482905511
We could add a nightly build to catch Cython 3 issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34726: GH-34564: [C++] Update code to compile with cython 3
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1482852034
:warning: GitHub issue #34564 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] da-woods commented on pull request #34726: GH-34564: [Python][C++] Update code to compile with cython 3
Posted by "da-woods (via GitHub)" <gi...@apache.org>.
da-woods commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1483189110
A couple of quick comments:
> * `&&` is no longer supported
> * nogil must appear at the end of the line
I think these are both warnings (so don't *have* to be breaking changes).
`&&` was never really supported. It just got interpreted as "reference to reference". Now we understand it in a few limited contexts, so issue a warning for the other contexts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #34726: GH-34564: [Python][C++] Update code to compile with cython 3
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1486485318
> The beta will not build due to known errors in the beta. I had to compile cython from the latest commit to get this to work.
@westonpace I see that a second beta was released yesterday. Should that in principle be sufficient? (not requiring to compile latest cython manually)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #34726: GH-34564: [Python][C++] Update code to compile with cython 3
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace merged PR #34726:
URL: https://github.com/apache/arrow/pull/34726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34726: GH-34564: [Python][C++] Update code to compile with cython 3
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34726:
URL: https://github.com/apache/arrow/pull/34726#issuecomment-1483700935
Benchmark runs are scheduled for baseline = e7d6c13d4ae3d8df0e9b668468b990f35c8a9556 and contender = c8e00969ee24e787901d6093d966f3e8a7fc4020. c8e00969ee24e787901d6093d966f3e8a7fc4020 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/27e84415e12e44bc800dbc1ec4aaa84f...29897e8a8dfc413b993bf95c5dbfb7c0/)
[Finished :arrow_down:0.24% :arrow_up:0.09%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ec47daf0585248fc9588d9ada9ea9047...5fd08896713a4b5e9f176af805cc25e4/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bd5c61a08f524318a6fe7f106bfbb083...d1b4473ddb8d4f7c82bba88d727d4515/)
[Finished :arrow_down:0.15% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5b5f02b205e04110bddebb8deaf5dfa5...daee24f35129423cb766f8491c320ad9/)
Buildkite builds:
[Finished] [`c8e00969` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2574)
[Finished] [`c8e00969` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2604)
[Finished] [`c8e00969` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2572)
[Finished] [`c8e00969` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2595)
[Finished] [`e7d6c13d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2573)
[Finished] [`e7d6c13d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2603)
[Finished] [`e7d6c13d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2571)
[Finished] [`e7d6c13d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2594)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org