[GitHub] [arrow] thisisnic commented on a diff in pull request #14387: ARROW-17665: [R] Document dplyr and compute functionality

[GitBox <gi...@apache.org>]

thisisnic commented on code in PR #14387:
URL: https://github.com/apache/arrow/pull/14387#discussion_r995836688


##########
r/R/arrow-package.R:
##########
@@ -38,27 +38,33 @@ supported_dplyr_methods <- list(
   select = NULL,
   filter = NULL,
   collect = NULL,
-  summarise = NULL,
+  summarise = c(
+    "window functions not currently supported;",
+    'arguments `.drop = FALSE` and `.groups = "rowwise" not supported'
+  ),
   group_by = NULL,
   groups = NULL,
   group_vars = NULL,
   group_by_drop_default = NULL,
   ungroup = NULL,
-  mutate = NULL,
+  mutate = c(
+    "window functions (e.g. things that require aggregation within groups)",

Review Comment:
   ```suggestion
       "window functions (i.e. things that require aggregation within groups)",
   ```
   nit, but only if window functions are literally defined by this, which I wasn't sure about



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org