You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 12:27:30 UTC
[I] [Bug] System alert acknowledge API should reject null request bodies [rocketmq-dashboard]
Aias00 opened a new issue, #856:
URL: https://github.com/apache/rocketmq-dashboard/issues/856
### What happened
`POST /api/system-alerts/acknowledge` accepts a JSON literal `null` request body. `SystemAlertController#acknowledgeAlert` then dereferences the request object before calling `AlertService`, so a null body can fail with an internal `NullPointerException` instead of a structured 400 response.
### Expected behavior
The system alert acknowledge endpoint should reject missing or JSON `null` request bodies with a clear 400 response and should not call the service when the request object is absent.
### Why this matters
System alert acknowledgement is part of the Studio operations and observability surface. Invalid write requests should fail predictably and avoid surfacing internal implementation errors.
### Scope
RocketMQ Studio / track 1 observability and operations alert management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] System alert acknowledge API should reject null request bodies [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #856:
URL: https://github.com/apache/rocketmq-dashboard/issues/856#issuecomment-5177573077
Resolved by #939 (merged into rocketmq-studio as 99f14ad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] System alert acknowledge API should reject null request bodies [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #856:
URL: https://github.com/apache/rocketmq-dashboard/issues/856#issuecomment-5547445625
**Issue Evaluation**
Category: | Status: **Already Fixed / Method Not Found**
The reported null-body issue does not match the current codebase.
**Findings:**
1. does not contain an method. The acknowledge functionality lives in (mapped to ).
2. already includes a null guard:
This is called before , so a null body returns HTTP 400.
The issue may reference an older API structure that has since been refactored. No further action needed. This issue can be closed.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] System alert acknowledge API should reject null request bodies [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #856: [Bug] System alert acknowledge API should reject null request bodies
URL: https://github.com/apache/rocketmq-dashboard/issues/856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org