You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/11/30 09:55:52 UTC
[PR] [FLINK-33703] Use maven 3.8.6 for release profile [flink-shaded]
snuyanzin opened a new pull request, #131:
URL: https://github.com/apache/flink-shaded/pull/131
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33703] Use maven 3.8.6 for release profile [flink-shaded]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #131:
URL: https://github.com/apache/flink-shaded/pull/131#discussion_r1418913528
##########
pom.xml:
##########
@@ -133,8 +133,7 @@ under the License.
<version>1.8.0</version>
</requireJavaVersion>
<requireMavenVersion>
- <!-- maven version must be lower than 3.3. See FLINK-3158 -->
- <version>(,3.3)</version>
+ <version>[3.8.6]</version>
Review Comment:
```suggestion
<!-- Maven version for releasing should match the Maven version used in CI (and Flink's main repo) -->
<version>[3.8.6]</version>
```
nit: can we add a bit more context to why this version is selected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33703] Use maven 3.8.6 for release profile [flink-shaded]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #131:
URL: https://github.com/apache/flink-shaded/pull/131#issuecomment-2666253912
Addressed feedback
also noticed that latest jackson 2.18.2 requires maven-shade-plugin 3.6.0 since it has a version folder for java 22.
And maven-shade-plugin 3.6.0 requires at least maven 3.6.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33703] Use maven 3.8.6 for release profile [flink-shaded]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #131:
URL: https://github.com/apache/flink-shaded/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org