You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/02/26 10:17:10 UTC

[kudu-CR] WIP: refactor cache a bit for contiguous key/value

Hello Sarah Jelinek,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2326

to review the following change.

Change subject: WIP: refactor cache a bit for contiguous key/value
......................................................................

WIP: refactor cache a bit for contiguous key/value

this is a WIP patch which does some refactoring to the cache
so that all caches expect a contiguous key and value. The
APIs are changed a bit so that the cache no longer tracks
a 'void*' pointer but rather always stores its data inline.

This may have some slight efficiency improvement for in-memory
cases, but mostly it's to simplify the integration of the NVM
patch.

In this WIP I commented out the NVM cache support to make it
quicker to refactor and test. Will try to work that code in
with the refactor tomorrow.

Change-Id: Ic822d0020431f8d3233034af0cd11c4f2f448a1e
---
M src/kudu/cfile/block_cache-test.cc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/block_cache.h
M src/kudu/cfile/block_handle.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/codegen/code_cache.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
11 files changed, 148 insertions(+), 189 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/2326/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic822d0020431f8d3233034af0cd11c4f2f448a1e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Sarah Jelinek <sj...@gmail.com>