You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/03/11 22:44:32 UTC

[royale-asjs] branch develop updated: tour-de-jewel: remove Add, Remove and Update beads since are now integrated into the Basic Mapper so not needed any more, RemoveAll is still needed

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 4186cfc  tour-de-jewel: remove Add, Remove and Update beads since are now integrated into the Basic Mapper so not needed any more, RemoveAll is still needed
4186cfc is described below

commit 4186cfcf50ff7c2a15e4cb4c22d6c3b27a6dd779
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Wed Mar 11 23:44:19 2020 +0100

    tour-de-jewel: remove Add, Remove and Update beads since are now integrated into the Basic Mapper so not needed any more, RemoveAll is still needed
---
 .../src/main/royale/AdvancedListPlayGround.mxml           | 12 ------------
 .../TourDeJewel/src/main/royale/DataGridPlayGround.mxml   |  3 ---
 .../TourDeJewel/src/main/royale/ListPlayGround.mxml       | 15 ++++++---------
 3 files changed, 6 insertions(+), 24 deletions(-)

diff --git a/examples/royale/TourDeJewel/src/main/royale/AdvancedListPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/AdvancedListPlayGround.mxml
index 4907c75..ab79cad 100644
--- a/examples/royale/TourDeJewel/src/main/royale/AdvancedListPlayGround.mxml
+++ b/examples/royale/TourDeJewel/src/main/royale/AdvancedListPlayGround.mxml
@@ -167,9 +167,6 @@ limitations under the License.
 								labelField="label">
 							<j:beads>
 								<js:ConstantBinding sourceID="listModel" sourcePropertyName="iconDetailListData" destinationPropertyName="dataProvider" />
-								<j:AddListItemRendererForArrayListData/>
-								<j:RemoveListItemRendererForArrayListData/>
-								<j:UpdateListItemRendererForArrayListData/>
 								<j:RemoveAllItemRendererForArrayListData/>
 							</j:beads>
 						</j:List>
@@ -200,9 +197,6 @@ limitations under the License.
 								dataProvider="{getFilteredALV(advancedIconList.dataProvider,'jewelFiltered', isJewel)}"
 								change="onChange(event)">
 							<j:beads>
-								<j:AddListItemRendererForArrayListData/>
-								<j:RemoveListItemRendererForArrayListData/>
-								<j:UpdateListItemRendererForArrayListData/>
 								<j:RemoveAllItemRendererForArrayListData/>
 								<j:CollectionChangeUpdateForArrayListData/>
 							</j:beads>
@@ -216,9 +210,6 @@ limitations under the License.
 								dataProvider="{getFilteredALV(advancedIconList.dataProvider,'basicFiltered', isBasic)}"
 								change="onChange(event)">
 							<j:beads>
-								<j:AddListItemRendererForArrayListData/>
-								<j:RemoveListItemRendererForArrayListData/>
-								<j:UpdateListItemRendererForArrayListData/>
 								<j:RemoveAllItemRendererForArrayListData/>
 								<j:CollectionChangeUpdateForArrayListData/>
 							</j:beads>
@@ -232,9 +223,6 @@ limitations under the License.
 								dataProvider="{getFilteredALV(advancedIconList.dataProvider,'jewelFilteredSorted', isJewel, reverseAlphaSort())}"
 								change="onChange(event)">
 							<j:beads>
-								<j:AddListItemRendererForArrayListData/>
-								<j:RemoveListItemRendererForArrayListData/>
-								<j:UpdateListItemRendererForArrayListData/>
 								<j:RemoveAllItemRendererForArrayListData/>
 								<j:CollectionChangeUpdateForArrayListData/>
 							</j:beads>
diff --git a/examples/royale/TourDeJewel/src/main/royale/DataGridPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/DataGridPlayGround.mxml
index 4608f65..a53ce31 100644
--- a/examples/royale/TourDeJewel/src/main/royale/DataGridPlayGround.mxml
+++ b/examples/royale/TourDeJewel/src/main/royale/DataGridPlayGround.mxml
@@ -334,9 +334,6 @@ limitations under the License.
 							<j:DataGridColumn label="Sales" dataField="sales" columnWidth="80" align="right"/>
 						</j:columns>
 						<j:beads>
-							<j:AddDataGridItemRendererForArrayListData/>
-							<j:RemoveDataGridItemRendererForArrayListData/>
-							<j:UpdateDataGridItemRendererForArrayListData/>
 							<j:RemoveAllDataGridItemRendererForArrayListData/>
 						</j:beads>
 					</j:DataGrid>
diff --git a/examples/royale/TourDeJewel/src/main/royale/ListPlayGround.mxml b/examples/royale/TourDeJewel/src/main/royale/ListPlayGround.mxml
index 24159c7..4a1127c 100644
--- a/examples/royale/TourDeJewel/src/main/royale/ListPlayGround.mxml
+++ b/examples/royale/TourDeJewel/src/main/royale/ListPlayGround.mxml
@@ -150,14 +150,14 @@ limitations under the License.
 		<j:GridCell desktopNumerator="1" desktopDenominator="2" tabletNumerator="1" tabletDenominator="2" phoneNumerator="1" phoneDenominator="1">
 			<j:Card>
 				<html:H3 text="Jewel List"/>
-				<j:List id="list" width="200" height="300" dataProvider="{simple}" change="onChange(event)"/>
+				<j:List localId="list" width="200" height="300" dataProvider="{simple}" change="onChange(event)"/>
 				<j:TextInput width="200">
 					<j:beads>
 						<j:TextPrompt prompt="filter list..."/>
 						<j:SearchFilterForList list="{list}"/>
 					</j:beads>
 				</j:TextInput>
-				<j:Label id="selected" html="{describeItem(list.selectedItem)}"/>
+				<j:Label localId="selected" html="{describeItem(list.selectedItem)}"/>
 				<j:HGroup gap="3" itemsVerticalAlign="itemsCentered">
 					<j:Label text="Select list by index: "/>
 					<j:NumericStepper valueChange="list.selectedIndex = event.target.value" minimum="0" maximum="11"/>
@@ -180,10 +180,7 @@ limitations under the License.
 							className="iconListItemRenderer" labelField="label"
 							emphasis="secondary" rowHeight="52">
 							<j:beads>
-								<js:ConstantBinding sourceID="listModel" sourcePropertyName="iconListData" destinationPropertyName="dataProvider" />
-								<j:AddListItemRendererForArrayListData/>
-								<j:RemoveListItemRendererForArrayListData/>
-								<j:UpdateListItemRendererForArrayListData/>
+								<js:ConstantBinding sourceID="listModel" sourcePropertyName="iconListData" destinationPropertyName="dataProvider"/>
 								<j:RemoveAllItemRendererForArrayListData/>
 							</j:beads>
 						</j:List>
@@ -202,7 +199,7 @@ limitations under the License.
 						<j:TextInput>
 							<j:beads>
 								<j:TextPrompt prompt="filter list..."/>
-								<j:SearchFilterForList id="filter" list="{iconList}"/>
+								<j:SearchFilterForList localId="filter" list="{iconList}"/>
 							</j:beads>
 						</j:TextInput>
 						<!-- <j:Button text="Trace Collection Labels" click="traceCollectionLabels()"/> -->
@@ -228,12 +225,12 @@ limitations under the License.
 		<j:GridCell desktopNumerator="1" desktopDenominator="2" tabletNumerator="1" tabletDenominator="2" phoneNumerator="1" phoneDenominator="1">
 			<j:Card>
 				<html:H3 text="Jewel List (Horizontal)"/>
-				<j:List id="alist" percentWidth="100" height="100">
+				<j:List localId="alist" percentWidth="100" height="100">
 					<j:beads>
 						<j:HorizontalLayout itemsExpand="true" />
 					</j:beads>
 					<j:dataProvider>
-						<js:ArrayList id="avengersCharacters" source="[Iron Man, Hulk, Thor, Captain America, Hawkeye]" />
+						<js:ArrayList localId="avengersCharacters" source="[Iron Man, Hulk, Thor, Captain America, Hawkeye]" />
 					</j:dataProvider>
 				</j:List>
 			</j:Card>