You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/05 09:53:00 UTC
[jira] [Commented] (ARTEMIS-1966) Replication channel closed but
not connection if flow controlled during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533456#comment-16533456 ]
ASF GitHub Bot commented on ARTEMIS-1966:
-----------------------------------------
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2171
ARTEMIS-1966 Replication channel closed but not connection if flow co…
We use SharedNothing Activation. If flow control occurs during replication, replication channel would be closed and enabled flag is set to false. After it, the message would not be sent to backup node. If live server crashes at this time, the backup node will fail over, resulting in data loss.
So we close connection if flow controlled, then backup node would be signaled failure replicating and restart server.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wy96f/activemq-artemis stop_connection_if_flowcontrolled
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2171
----
commit 0781b1d8407105aeeeb1ae1437cb8ee490e1cc9f
Author: yang wei <wy...@...>
Date: 2018-07-05T09:48:11Z
ARTEMIS-1966 Replication channel closed but not connection if flow controlled during replication
----
> Replication channel closed but not connection if flow controlled during replication
> -----------------------------------------------------------------------------------
>
> Key: ARTEMIS-1966
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1966
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.2
> Reporter: yangwei
> Priority: Major
>
> We use SharedNothing Activation. If flow control occurs during replication, replication channel would be closed and enabled flag is set to false. After it, the message would not be sent to backup node. If live server crashes at this time, the backup node will fail over, resulting in data loss.
> So we close connection if flow controlled, then backup node would be signaled failure replicating and restart server.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)