You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2013/08/05 23:12:39 UTC
Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13298/
-----------------------------------------------------------
Review request for cloudstack, Alena Prokharchyk, Chip Childers, and Min Chen.
Bugs: CLOUDSTACK-4091
Repository: cloudstack-git
Description
-------
Putting in upgrade path for db upgrade from 4.1.1 to 4.1.2. Prior to the patch, th mgmt server doesn't start up successfully on 4.1.
Diffs
-----
server/src/com/cloud/upgrade/DatabaseUpgradeChecker.java a7a4e61
server/src/com/cloud/upgrade/dao/Upgrade411to412.java PRE-CREATION
setup/db/db/schema-411to412.sql PRE-CREATION
Diff: https://reviews.apache.org/r/13298/diff/
Testing
-------
Mgmt server comes up successfully upon fresh install of 4.1, and the db version shows the right value:
mysql> select * from version;
+----+---------+---------------------+----------+
| id | version | updated | step |
+----+---------+---------------------+----------+
| 1 | 4.0.0 | 2013-08-05 07:40:38 | Complete |
| 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
| 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
| 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
+----+---------+---------------------+----------+
4 rows in set (0.00 sec)
mysql>
Thanks,
Venkata Siva Vijayendra Bhamidipati
RE: Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
Posted by Vijayendra Bhamidipati <vi...@citrix.com>.
Will send out a patch shortly.
Regards,
Vijay
-----Original Message-----
From: Marcus Sorensen [mailto:shadowsor@gmail.com]
Sent: Wednesday, August 07, 2013 3:09 PM
To: dev@cloudstack.apache.org; Alena Prokharchyk
Cc: Min Chen; Chip Childers; cloudstack; Vijayendra Bhamidipati
Subject: Re: Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
Let's get this applied! 4.1 branch has been broken for over a week!
On Wed, Aug 7, 2013 at 11:48 AM, Alena Prokharchyk <al...@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13298/#review24813
> -----------------------------------------------------------
>
>
> Vijay, as the schema is empty, you don't have to have this file. Remove it pls, as well as the reference to it from the corresponding Java code.
>
> - Alena Prokharchyk
>
>
> On Aug. 5, 2013, 9:12 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/13298/
>> -----------------------------------------------------------
>>
>> (Updated Aug. 5, 2013, 9:12 p.m.)
>>
>>
>> Review request for cloudstack, Alena Prokharchyk, Chip Childers, and Min Chen.
>>
>>
>> Bugs: CLOUDSTACK-4091
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Putting in upgrade path for db upgrade from 4.1.1 to 4.1.2. Prior to the patch, th mgmt server doesn't start up successfully on 4.1.
>>
>>
>> Diffs
>> -----
>>
>> server/src/com/cloud/upgrade/DatabaseUpgradeChecker.java a7a4e61
>> server/src/com/cloud/upgrade/dao/Upgrade411to412.java PRE-CREATION
>> setup/db/db/schema-411to412.sql PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/13298/diff/
>>
>>
>> Testing
>> -------
>>
>> Mgmt server comes up successfully upon fresh install of 4.1, and the db version shows the right value:
>>
>> mysql> select * from version;
>> +----+---------+---------------------+----------+
>> | id | version | updated | step |
>> +----+---------+---------------------+----------+
>> | 1 | 4.0.0 | 2013-08-05 07:40:38 | Complete |
>> | 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
>> | 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
>> | 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
>> +----+---------+---------------------+----------+
>> 4 rows in set (0.00 sec)
>>
>> mysql>
>>
>>
>> Thanks,
>>
>> Venkata Siva Vijayendra Bhamidipati
>>
>>
>
Re: Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
Posted by Marcus Sorensen <sh...@gmail.com>.
Let's get this applied! 4.1 branch has been broken for over a week!
On Wed, Aug 7, 2013 at 11:48 AM, Alena Prokharchyk
<al...@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13298/#review24813
> -----------------------------------------------------------
>
>
> Vijay, as the schema is empty, you don't have to have this file. Remove it pls, as well as the reference to it from the corresponding Java code.
>
> - Alena Prokharchyk
>
>
> On Aug. 5, 2013, 9:12 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/13298/
>> -----------------------------------------------------------
>>
>> (Updated Aug. 5, 2013, 9:12 p.m.)
>>
>>
>> Review request for cloudstack, Alena Prokharchyk, Chip Childers, and Min Chen.
>>
>>
>> Bugs: CLOUDSTACK-4091
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> Putting in upgrade path for db upgrade from 4.1.1 to 4.1.2. Prior to the patch, th mgmt server doesn't start up successfully on 4.1.
>>
>>
>> Diffs
>> -----
>>
>> server/src/com/cloud/upgrade/DatabaseUpgradeChecker.java a7a4e61
>> server/src/com/cloud/upgrade/dao/Upgrade411to412.java PRE-CREATION
>> setup/db/db/schema-411to412.sql PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/13298/diff/
>>
>>
>> Testing
>> -------
>>
>> Mgmt server comes up successfully upon fresh install of 4.1, and the db version shows the right value:
>>
>> mysql> select * from version;
>> +----+---------+---------------------+----------+
>> | id | version | updated | step |
>> +----+---------+---------------------+----------+
>> | 1 | 4.0.0 | 2013-08-05 07:40:38 | Complete |
>> | 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
>> | 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
>> | 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
>> +----+---------+---------------------+----------+
>> 4 rows in set (0.00 sec)
>>
>> mysql>
>>
>>
>> Thanks,
>>
>> Venkata Siva Vijayendra Bhamidipati
>>
>>
>
Re: Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13298/#review24813
-----------------------------------------------------------
Vijay, as the schema is empty, you don't have to have this file. Remove it pls, as well as the reference to it from the corresponding Java code.
- Alena Prokharchyk
On Aug. 5, 2013, 9:12 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13298/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2013, 9:12 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chip Childers, and Min Chen.
>
>
> Bugs: CLOUDSTACK-4091
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Putting in upgrade path for db upgrade from 4.1.1 to 4.1.2. Prior to the patch, th mgmt server doesn't start up successfully on 4.1.
>
>
> Diffs
> -----
>
> server/src/com/cloud/upgrade/DatabaseUpgradeChecker.java a7a4e61
> server/src/com/cloud/upgrade/dao/Upgrade411to412.java PRE-CREATION
> setup/db/db/schema-411to412.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13298/diff/
>
>
> Testing
> -------
>
> Mgmt server comes up successfully upon fresh install of 4.1, and the db version shows the right value:
>
> mysql> select * from version;
> +----+---------+---------------------+----------+
> | id | version | updated | step |
> +----+---------+---------------------+----------+
> | 1 | 4.0.0 | 2013-08-05 07:40:38 | Complete |
> | 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
> | 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
> | 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
> +----+---------+---------------------+----------+
> 4 rows in set (0.00 sec)
>
> mysql>
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13298/#review24840
-----------------------------------------------------------
Pushed the patch to 4.1 branch with commit id ae8159b8560181f5935443876862f8b826bc0a31. Not closing the ticket as another patch has to be submitted to master branch.
- Alena Prokharchyk
On Aug. 7, 2013, 10:44 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13298/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 10:44 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chip Childers, and Min Chen.
>
>
> Bugs: CLOUDSTACK-4091
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Putting in upgrade path for db upgrade from 4.1.1 to 4.1.2. Prior to the patch, th mgmt server doesn't start up successfully on 4.1.
>
>
> Diffs
> -----
>
> server/src/com/cloud/upgrade/DatabaseUpgradeChecker.java a7a4e61
> server/src/com/cloud/upgrade/dao/Upgrade411to412.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13298/diff/
>
>
> Testing
> -------
>
> Mgmt server comes up successfully upon fresh install of 4.1, and the db version shows the right value:
>
> mysql> select * from version;
> +----+---------+---------------------+----------+
> | id | version | updated | step |
> +----+---------+---------------------+----------+
> | 1 | 4.0.0 | 2013-08-05 07:40:38 | Complete |
> | 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
> | 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
> | 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
> +----+---------+---------------------+----------+
> 4 rows in set (0.00 sec)
>
> mysql>
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
Posted by Alena Prokharchyk <al...@citrix.com>.
> On Aug. 7, 2013, 10:58 p.m., Alena Prokharchyk wrote:
> > Ship It!
Vijay will open a separate reviewboard request for 411-412 upgrade path for master branch. The patch is going to be different given the presence of 4.2 release.
- Alena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13298/#review24841
-----------------------------------------------------------
On Aug. 7, 2013, 10:44 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13298/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 10:44 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chip Childers, and Min Chen.
>
>
> Bugs: CLOUDSTACK-4091
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Putting in upgrade path for db upgrade from 4.1.1 to 4.1.2. Prior to the patch, th mgmt server doesn't start up successfully on 4.1.
>
>
> Diffs
> -----
>
> server/src/com/cloud/upgrade/DatabaseUpgradeChecker.java a7a4e61
> server/src/com/cloud/upgrade/dao/Upgrade411to412.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13298/diff/
>
>
> Testing
> -------
>
> Mgmt server comes up successfully upon fresh install of 4.1, and the db version shows the right value:
>
> mysql> select * from version;
> +----+---------+---------------------+----------+
> | id | version | updated | step |
> +----+---------+---------------------+----------+
> | 1 | 4.0.0 | 2013-08-05 07:40:38 | Complete |
> | 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
> | 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
> | 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
> +----+---------+---------------------+----------+
> 4 rows in set (0.00 sec)
>
> mysql>
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13298/#review24841
-----------------------------------------------------------
Ship it!
Ship It!
- Alena Prokharchyk
On Aug. 7, 2013, 10:44 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13298/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 10:44 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Chip Childers, and Min Chen.
>
>
> Bugs: CLOUDSTACK-4091
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Putting in upgrade path for db upgrade from 4.1.1 to 4.1.2. Prior to the patch, th mgmt server doesn't start up successfully on 4.1.
>
>
> Diffs
> -----
>
> server/src/com/cloud/upgrade/DatabaseUpgradeChecker.java a7a4e61
> server/src/com/cloud/upgrade/dao/Upgrade411to412.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13298/diff/
>
>
> Testing
> -------
>
> Mgmt server comes up successfully upon fresh install of 4.1, and the db version shows the right value:
>
> mysql> select * from version;
> +----+---------+---------------------+----------+
> | id | version | updated | step |
> +----+---------+---------------------+----------+
> | 1 | 4.0.0 | 2013-08-05 07:40:38 | Complete |
> | 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
> | 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
> | 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
> +----+---------+---------------------+----------+
> 4 rows in set (0.00 sec)
>
> mysql>
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13298/
-----------------------------------------------------------
(Updated Aug. 8, 2013, 2:43 a.m.)
Review request for cloudstack, Alena Prokharchyk, Chip Childers, and Min Chen.
Changes
-------
Uploading diffs for the new upgrade path for 4.2. The patch has been tested on an upgrade from 4.1 (the latest 4.1 will set the db version at 4.1.2) to 4.2 (which sets the version to 4.2.0). The db version output is pasted below:
When at 4.1.2:
mysql> select * from version;
+----+---------+---------------------+----------+
| id | version | updated | step |
+----+---------+---------------------+----------+
| 1 | 4.0.0 | 2013-08-07 13:04:04 | Complete |
| 2 | 4.1.0 | 2013-08-07 20:05:41 | Complete |
| 3 | 4.1.1 | 2013-08-07 20:05:41 | Complete |
| 4 | 4.1.2 | 2013-08-07 20:05:41 | Complete |
+----+---------+---------------------+----------+
4 rows in set (0.00 sec)
Then, after the upgrade to 4.2:
mysql> select * from version;
+----+---------+---------------------+----------+
| id | version | updated | step |
+----+---------+---------------------+----------+
| 1 | 4.0.0 | 2013-08-07 13:04:04 | Complete |
| 2 | 4.1.0 | 2013-08-07 20:05:41 | Complete |
| 3 | 4.1.1 | 2013-08-07 20:05:41 | Complete |
| 4 | 4.1.2 | 2013-08-07 20:05:41 | Complete |
| 5 | 4.2.0 | 2013-08-07 20:16:12 | Complete |
+----+---------+---------------------+----------+
5 rows in set (0.00 sec)
Bugs: CLOUDSTACK-4091
Repository: cloudstack-git
Description
-------
Putting in upgrade path for db upgrade from 4.1.1 to 4.1.2. Prior to the patch, th mgmt server doesn't start up successfully on 4.1.
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 7232058
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to411.java PRE-CREATION
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 5a6c5b0
engine/schema/src/com/cloud/upgrade/dao/Upgrade411to412.java PRE-CREATION
setup/db/db/schema-410to420-cleanup.sql b65717f
setup/db/db/schema-410to420.sql fdb53a3
Diff: https://reviews.apache.org/r/13298/diff/
Testing
-------
Mgmt server comes up successfully upon fresh install of 4.1, and the db version shows the right value:
mysql> select * from version;
+----+---------+---------------------+----------+
| id | version | updated | step |
+----+---------+---------------------+----------+
| 1 | 4.0.0 | 2013-08-05 07:40:38 | Complete |
| 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
| 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
| 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
+----+---------+---------------------+----------+
4 rows in set (0.00 sec)
mysql>
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request 13298: Put in upgrade path from 4.1.1 to 4.1.2
Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13298/
-----------------------------------------------------------
(Updated Aug. 7, 2013, 10:44 p.m.)
Review request for cloudstack, Alena Prokharchyk, Chip Childers, and Min Chen.
Changes
-------
New patch on top of latest 4.1 incorporating Alena's review comments.
Bugs: CLOUDSTACK-4091
Repository: cloudstack-git
Description
-------
Putting in upgrade path for db upgrade from 4.1.1 to 4.1.2. Prior to the patch, th mgmt server doesn't start up successfully on 4.1.
Diffs (updated)
-----
server/src/com/cloud/upgrade/DatabaseUpgradeChecker.java a7a4e61
server/src/com/cloud/upgrade/dao/Upgrade411to412.java PRE-CREATION
Diff: https://reviews.apache.org/r/13298/diff/
Testing
-------
Mgmt server comes up successfully upon fresh install of 4.1, and the db version shows the right value:
mysql> select * from version;
+----+---------+---------------------+----------+
| id | version | updated | step |
+----+---------+---------------------+----------+
| 1 | 4.0.0 | 2013-08-05 07:40:38 | Complete |
| 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
| 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
| 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
+----+---------+---------------------+----------+
4 rows in set (0.00 sec)
mysql>
Thanks,
Venkata Siva Vijayendra Bhamidipati