You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "numinnex (via GitHub)" <gi...@apache.org> on 2026/08/21 10:58:22 UTC
[PR] fix(consensus): keep a late retry's reply instead of refusing it [iggy]
numinnex opened a new pull request, #3945:
URL: https://github.com/apache/iggy/pull/3945
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(consensus): keep a late retry's reply instead of refusing it [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #3945:
URL: https://github.com/apache/iggy/pull/3945#discussion_r3870757344
##########
core/consensus/src/client_table.rs:
##########
@@ -1687,14 +1731,29 @@ impl ClientEntry {
.find(|cached| cached.header().request == request)
}
- /// Push the newest committed reply, evicting the oldest when full, and
- /// refresh the denormalized `latest_commit`.
+ /// Push the newest committed reply, drop the oldest ones retention no
+ /// longer covers, and refresh the denormalized `latest_commit`.
fn push_latest(&mut self, cached: CachedReply) {
self.latest_commit = cached.header().commit;
- if self.ring.len() == REPLY_RING_CAPACITY {
- self.ring.pop_front();
- }
self.ring.push_back(cached);
+ self.trim_ring();
+ }
+
+ /// Drop the oldest replies once the entry holds more than
+ /// [`REPLY_RING_CAPACITY`] and either retention bound is exceeded.
+ ///
+ /// The total is summed here rather than denormalized onto the entry: the
+ /// ring is capped at [`REPLY_RING_MAX_CAPACITY`], so this is a bounded walk
+ /// of buffer lengths with no header casts, and it leaves no running total
+ /// for the sites that write the ring to drift out of sync with.
+ fn trim_ring(&mut self) {
+ let mut bytes: usize = self.ring.iter().map(CachedReply::byte_len).sum();
+ while self.ring.len() > REPLY_RING_CAPACITY
+ && (self.ring.len() > REPLY_RING_MAX_CAPACITY || bytes > REPLY_RING_RETENTION_BYTES)
Review Comment:
this disjunct can never fire. `ReplyHeader` is 256 bytes and `try_into_typed` rejects any backing shorter than the header, so `bytes > REPLY_RING_RETENTION_BYTES` already trips at 33 replies - `ring.len() > REPLY_RING_MAX_CAPACITY` at 64 is unreachable, and the tiny-reply flood its doc describes can't exist. the real cap is 8192 / 256 = 32.
drop the disjunct here, then either delete the constant or define it as `REPLY_RING_RETENTION_BYTES / size_of::<ReplyHeader>()` and keep it only for the wire check. its doc at line 166 is stale either way - `encode` writes `transferable_replies().count()` now, so the u8 limit constrains `REPLY_RING_CAPACITY`, not this one. `decode_rejects_a_ring_longer_than_capacity` at line 3215 needs a rename to match whichever bound survives.
##########
core/consensus/src/client_table.rs:
##########
@@ -135,8 +140,36 @@ pub const CLIENTS_TABLE_SLOT_MAX: usize = 1 << 16;
/// original bytes instead of a bare "already applied"; losing one
/// degrades the answer, never correctness. In-memory only: ring contents are
/// refcount bumps and are never persisted or transferred.
+///
+/// This many replies are retained unconditionally, whatever they weigh, which
+/// is what bounds the memory a client holding megabyte replies can pin.
+/// Retention past it is governed by [`REPLY_RING_RETENTION_BYTES`]: a client
+/// sending small operations -- the common case -- keeps a far deeper replay
+/// history for the same memory, so a retry that arrives late still replays its
+/// original bytes instead of drawing a bare "already applied".
pub const REPLY_RING_CAPACITY: usize = 5;
+/// Byte budget for the replies retained past [`REPLY_RING_CAPACITY`].
+///
+/// Deep retention exists for the slow retrier: a request whose reply aged out
+/// can only be answered "already applied, reply gone", which tells the caller
+/// its operation succeeded but hands back no result. Sizing the extra
+/// retention in bytes rather than in replies spends the same memory where it
+/// buys the most history.
+///
+/// The added cost is bounded by this budget per occupied slot, and it is less
+/// than the [`REPLY_RING_CAPACITY`] floor already costs for any reply above
+/// roughly 1.6 KiB, so a table full of large replies is dominated by the floor
+/// exactly as it was before.
+pub const REPLY_RING_RETENTION_BYTES: usize = 8 * 1024;
Review Comment:
worth spelling out what this actually costs. at the default `clients_table_max` of 8192 with header-only replies (256 bytes, the common metadata reply), per-slot retention goes from 5 x 256 = 1.25 KiB to 8 KiB, so a full table goes from 10 MiB to 64 MiB and live `Frozen` buffers from 41k to 262k. at the 65536 ceiling it's 512 MiB. the doc reads cost-neutral ("spends the same memory where it buys the most history") but it's 6.4x on the common case - say the multiplied figure.
also, where does 8 KiB come from? nothing ties 32 replies of depth to an observed retry depth or to how wide clients actually pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(consensus): keep a late retry's reply instead of refusing it [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz commented on code in PR #3945:
URL: https://github.com/apache/iggy/pull/3945#discussion_r3870696356
##########
core/integration/tests/cluster/client_table_adversarial.rs:
##########
@@ -165,8 +163,8 @@ async fn given_replays_past_the_reply_ring_when_a_request_id_falls_off_should_no
let aged_payload = create_stream_payload("adv-l-aged");
let committed = commit_request(&mut stream, CLIENT_A, session, 1, &aged_payload).await;
- // One more commit than the ring holds, so request 1's reply is evicted
- // even though the register reply seeded a slot of its own.
+ // More commits than the unconditional floor holds, so passing depends on
+ // the byte-budgeted retention rather than on the floor alone.
let later_requests = REPLY_RING_CAPACITY as u64 + 1;
Review Comment:
This test no longer exercises the behavior described by its name. Request 1 does not fall out of the cache. The test only proves that these replies fit within the new retention budget. `check_request_below_watermark_past_retention_is_already_applied` still confirms that a sufficiently late retry receives terminal `RequestAlreadyApplied`. Please either restore a test where the reply actually ages out and fix that outcome, or explicitly reframe this PR as a bounded cache-depth mitigation rather than a fix for replies that have fallen out.
##########
core/integration/tests/cluster/client_table_adversarial.rs:
##########
Review Comment:
This module documentation is stale. The test is no longer ignored or expected to fail, and entries may retain more than `REPLY_RING_CAPACITY` replies. Please update this description to match the new behavior and its bounded retention semantics.
##########
core/consensus/src/client_table.rs:
##########
@@ -1679,6 +1710,19 @@ impl ClientEntry {
.expect("ring is never empty after registration")
}
+ /// The newest replies a state transfer carries, oldest first.
+ ///
+ /// Capped at [`REPLY_RING_CAPACITY`] rather than shipping whatever
+ /// retention holds locally: an artifact a recovering node has to fetch is
+ /// worth keeping small, and the deeper history rebuilds itself from the
+ /// receiver's own commits. Dropping it costs a late retrier its bytes on
+ /// the transferred node, which the watermark still refuses to re-execute.
+ fn transferable_replies(&self) -> impl Iterator<Item = &CachedReply> {
Review Comment:
Capping state transfer at `REPLY_RING_CAPACITY` discards the deeper history introduced by this PR. A request that remains replayable on the serving replica can become `AlreadyApplied` immediately after transfer, and the receiving replica can later become primary. Checkpoint recovery has the same problem because `to_snapshot` stores only `entry.latest()`. Please preserve the advertised retention consistently across recovery and state transfer, or explicitly define and test that the guarantee is limited to uninterrupted in-memory operation.
##########
core/consensus/src/client_table.rs:
##########
@@ -1556,15 +1588,14 @@ impl ClientTable {
return Err(ClientTableWireError::EmptyRing);
}
// The artifact checksum only proves the bytes survived transit; it
- // says nothing about the peer that computed them. An over-capacity
- // ring is admitted forever after (`push_latest` evicts only on
- // equality) and eventually wraps `encode`'s `u8` length, making
- // this table permanently un-transferable onward.
- if usize::from(ring_len) > REPLY_RING_CAPACITY {
+ // says nothing about the peer that computed them. A ring longer
+ // than this crate retains eventually wraps `encode`'s `u8` length,
+ // making this table permanently un-transferable onward.
+ if usize::from(ring_len) > REPLY_RING_MAX_CAPACITY {
Review Comment:
The decoder now accepts up to 64 replies, but this version's encoder emits at most `REPLY_RING_CAPACITY`, which is five. It also installs the received ring without applying the byte-retention limit. This allows peer input to create an untrimmed state that the local encoder cannot produce. Please keep the wire validation bound aligned with `transferable_replies()`, or validate both the count and byte budget if larger transferred rings are intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(consensus): keep a late retry's reply instead of refusing it [iggy]
Posted by "numinnex (via GitHub)" <gi...@apache.org>.
numinnex commented on PR #3945:
URL: https://github.com/apache/iggy/pull/3945#issuecomment-5368964905
Merge after #3944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(consensus): keep a late retry's reply instead of refusing it [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #3945:
URL: https://github.com/apache/iggy/pull/3945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(consensus): keep a late retry's reply instead of refusing it [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3945:
URL: https://github.com/apache/iggy/pull/3945#issuecomment-5369015725
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3945?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.09657%` with `70 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.63%. Comparing base ([`c0c7493`](https://app.codecov.io/gh/apache/iggy/commit/c0c74931b1727169daea06dcd438478640ce09f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0be79b0`](https://app.codecov.io/gh/apache/iggy/commit/0be79b0c62a78c081225ef9da7c4b6b6c803c378?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3945?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...SDK/IggyClient/Implementations/TcpMessageStream.cs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FIggyClient%2FImplementations%2FTcpMessageStream.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvSWdneUNsaWVudC9JbXBsZW1lbnRhdGlvbnMvVGNwTWVzc2FnZVN0cmVhbS5jcw==) | 72.88% | [12 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/sdk/src/leader\_aware.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fleader_aware.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2xlYWRlcl9hd2FyZS5ycw==) | 80.00% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/sdk/src/tcp/tcp\_client.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Ftcp%2Ftcp_client.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL3RjcC90Y3BfY2xpZW50LnJz) | 90.51% | [10 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [foreign/go/client/tcp/tcp\_core.go](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=foreign%2Fgo%2Fclient%2Ftcp%2Ftcp_core.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9nby9jbGllbnQvdGNwL3RjcF9jb3JlLmdv) | 80.76% | [7 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/consensus/src/client\_table.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Fclient_table.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL2NsaWVudF90YWJsZS5ycw==) | 96.59% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/shard/src/router.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fshard%2Fsrc%2Frouter.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaGFyZC9zcmMvcm91dGVyLnJz) | 62.50% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [foreign/node/src/client/client.connection.ts](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=foreign%2Fnode%2Fsrc%2Fclient%2Fclient.connection.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9ub2RlL3NyYy9jbGllbnQvY2xpZW50LmNvbm5lY3Rpb24udHM=) | 95.45% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/server\_common/src/consensus\_message.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fserver_common%2Fsrc%2Fconsensus_message.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXJfY29tbW9uL3NyYy9jb25zZW5zdXNfbWVzc2FnZS5ycw==) | 85.71% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [foreign/go/client/tcp/tcp\_session\_management.go](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=foreign%2Fgo%2Fclient%2Ftcp%2Ftcp_session_management.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9nby9jbGllbnQvdGNwL3RjcF9zZXNzaW9uX21hbmFnZW1lbnQuZ28=) | 81.81% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...figuration/tcp\_config/tcp\_client\_config\_builder.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftypes%2Fconfiguration%2Ftcp_config%2Ftcp_client_config_builder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3R5cGVzL2NvbmZpZ3VyYXRpb24vdGNwX2NvbmZpZy90Y3BfY2xpZW50X2NvbmZpZ19idWlsZGVyLnJz) | 95.65% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3945 +/- ##
============================================
- Coverage 83.87% 81.63% -2.25%
+ Complexity 1358 1355 -3
============================================
Files 1212 1213 +1
Lines 166843 167039 +196
Branches 134306 134528 +222
============================================
- Hits 139937 136357 -3580
- Misses 23266 27058 +3792
+ Partials 3640 3624 -16
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3945/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3945/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.53% <91.05%> (-0.12%)` | :arrow_down: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3945/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.61% <ø> (-0.07%)` | :arrow_down: |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3945/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.73% <77.14%> (-29.82%)` | :arrow_down: |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3945/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.13% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3945/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.48% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3945/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `93.95% <95.89%> (-1.90%)` | :arrow_down: |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3945/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.64% <80.95%> (-13.68%)` | :arrow_down: |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3945?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/binary\_protocol/src/consensus/header.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fconsensus%2Fheader.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL2NvbnNlbnN1cy9oZWFkZXIucnM=) | `81.56% <ø> (ø)` | |
| [core/binary\_protocol/src/consensus/operation.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fbinary_protocol%2Fsrc%2Fconsensus%2Foperation.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9iaW5hcnlfcHJvdG9jb2wvc3JjL2NvbnNlbnN1cy9vcGVyYXRpb24ucnM=) | `97.54% <100.00%> (+0.06%)` | :arrow_up: |
| [.../src/traits/binary\_impls/personal\_access\_tokens.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftraits%2Fbinary_impls%2Fpersonal_access_tokens.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3RyYWl0cy9iaW5hcnlfaW1wbHMvcGVyc29uYWxfYWNjZXNzX3Rva2Vucy5ycw==) | `100.00% <ø> (ø)` | |
| [core/common/src/traits/binary\_impls/users.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftraits%2Fbinary_impls%2Fusers.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3RyYWl0cy9iaW5hcnlfaW1wbHMvdXNlcnMucnM=) | `100.00% <ø> (ø)` | |
| [core/common/src/traits/binary\_transport.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftraits%2Fbinary_transport.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3RyYWl0cy9iaW5hcnlfdHJhbnNwb3J0LnJz) | `100.00% <100.00%> (ø)` | |
| [...ypes/configuration/tcp\_config/tcp\_client\_config.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftypes%2Fconfiguration%2Ftcp_config%2Ftcp_client_config.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3R5cGVzL2NvbmZpZ3VyYXRpb24vdGNwX2NvbmZpZy90Y3BfY2xpZW50X2NvbmZpZy5ycw==) | `100.00% <100.00%> (ø)` | |
| [core/consensus/src/metadata\_helpers.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Fmetadata_helpers.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL21ldGFkYXRhX2hlbHBlcnMucnM=) | `93.90% <ø> (-0.02%)` | :arrow_down: |
| [core/sdk/src/client\_provider.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclient_provider.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudF9wcm92aWRlci5ycw==) | `48.36% <100.00%> (+0.33%)` | :arrow_up: |
| [core/server/src/partition\_reconciler.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fpartition_reconciler.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL3BhcnRpdGlvbl9yZWNvbmNpbGVyLnJz) | `97.80% <100.00%> (+0.03%)` | :arrow_up: |
| [core/shard/src/metrics.rs](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree&filepath=core%2Fshard%2Fsrc%2Fmetrics.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaGFyZC9zcmMvbWV0cmljcy5ycw==) | `86.55% <ø> (ø)` | |
| ... and [19 more](https://app.codecov.io/gh/apache/iggy/pull/3945?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [149 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3945/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(consensus): keep a late retry's reply instead of refusing it [iggy]
Posted by "numinnex (via GitHub)" <gi...@apache.org>.
numinnex commented on PR #3945:
URL: https://github.com/apache/iggy/pull/3945#issuecomment-5437627585
/ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org