You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li via Review Board <no...@reviews.apache.org> on 2018/06/01 18:13:29 UTC

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65704/
-----------------------------------------------------------

(Updated June 1, 2018, 6:13 p.m.)


Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Sergio Pena.


Repository: sentry


Description
-------

wait for HMS sync at alter table, which including table rename and changing table columns

This issue is currently blocked by "(HIVE-18783) Set Notification ID for Alter Table event". testRenameTablesWithinDBSinglePrivilege fails when table rename does not synchronize with sentry.


Diffs (updated)
-----

  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java 7b2d8be 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java cbfdb94 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 04c679f 


Diff: https://reviews.apache.org/r/65704/diff/7/

Changes: https://reviews.apache.org/r/65704/diff/6-7/


Testing
-------

unit tests succeeded


Thanks,

Na Li


Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65704/#review204197
-----------------------------------------------------------


Ship it!




Ship It!

- Sergio Pena


On June 1, 2018, 6:13 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65704/
> -----------------------------------------------------------
> 
> (Updated June 1, 2018, 6:13 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> wait for HMS sync at alter table, which including table rename and changing table columns
> 
> This issue is currently blocked by "(HIVE-18783) Set Notification ID for Alter Table event". testRenameTablesWithinDBSinglePrivilege fails when table rename does not synchronize with sentry.
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java 7b2d8be 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java cbfdb94 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 04c679f 
> 
> 
> Diff: https://reviews.apache.org/r/65704/diff/7/
> 
> 
> Testing
> -------
> 
> unit tests succeeded
> 
> 
> Thanks,
> 
> Na Li
> 
>