You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/04/03 02:47:05 UTC
[GitHub] [cordova-plugin-statusbar] XxAdi101xX commented on a change in pull
request #134: WIP: implementation to get statusbar height (top-inset)
XxAdi101xX commented on a change in pull request #134: WIP: implementation to get statusbar height (top-inset)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/134#discussion_r271562639
##########
File path: src/browser/StatusBarProxy.js
##########
@@ -18,33 +18,33 @@
*
*/
-function notSupported(win,fail) {
- //
- console.log('StatusBar is not supported');
- setTimeout(function(){
- if (win) {
- win();
- }
- // note that while it is not explicitly supported, it does not fail
- // this is really just here to allow developers to test their code in the browser
- // and if we fail, then their app might as well. -jm
- },0);
+function notSupported(win, fail) {
+ //
+ console.log("StatusBar is not supported");
+ setTimeout(function() {
+ if (win) {
+ win();
+ }
+ // note that while it is not explicitly supported, it does not fail
+ // this is really just here to allow developers to test their code in the browser
+ // and if we fail, then their app might as well. -jm
+ }, 0);
}
module.exports = {
Review comment:
most of these changes are spacing issues, I've only added a default height of 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org