You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/07 11:06:40 UTC
Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef
constraints and brought back legacy flags isComposite/reverseAttributeName
using constraints owner/inverseRef(attribute=attr1)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1526
https://issues.apache.org/jira/browse/ATLAS-1526
Repository: atlas
Description
-------
constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
Diffs
-----
addons/models/0030-hive_model.json 5ae16cf
addons/models/0060-hbase_model.json 5febbbc
addons/models/0080-storm_model.json 344227d
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93
intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java d48c87e
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f507ae0
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 2e9e5e4
webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 1559eb9
webapp/src/main/java/org/apache/atlas/util/RestUtils.java cecf636
Diff: https://reviews.apache.org/r/56380/diff/
Testing
-------
updated unit tests and verified that existing unit tests pass
Thanks,
Madhan Neethiraj
Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef
constraints and brought back legacy flags isComposite/reverseAttributeName
using constraints owner/inverseRef(attribute=attr1)
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164601
-----------------------------------------------------------
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java (line 410)
<https://reviews.apache.org/r/56380/#comment236367>
extra whitespace
- Jeff Hagelberg
On Feb. 7, 2017, 10:55 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56380/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:55 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1526
> https://issues.apache.org/jira/browse/ATLAS-1526
>
>
> Repository: atlas
>
>
> Description
> -------
>
> constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 5ae16cf
> addons/models/0060-hbase_model.json 5febbbc
> addons/models/0080-storm_model.json 344227d
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 69cf60a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f507ae0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 2e9e5e4
> webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d8202a5
> webapp/src/main/java/org/apache/atlas/util/RestUtils.java 9d4b04e
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 4158f01
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6187cfb
>
> Diff: https://reviews.apache.org/r/56380/diff/
>
>
> Testing
> -------
>
> updated unit tests and verified that existing unit tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef
constraints and brought back legacy flags isComposite/reverseAttributeName
using constraints owner/inverseRef(attribute=attr1)
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
> On Feb. 8, 2017, 12:43 a.m., Jeff Hagelberg wrote:
> > Just a few minor comments.
That was supposd to be "Fix it, then Ship It!"
- Jeff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164599
-----------------------------------------------------------
On Feb. 7, 2017, 10:55 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56380/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:55 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1526
> https://issues.apache.org/jira/browse/ATLAS-1526
>
>
> Repository: atlas
>
>
> Description
> -------
>
> constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 5ae16cf
> addons/models/0060-hbase_model.json 5febbbc
> addons/models/0080-storm_model.json 344227d
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 69cf60a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f507ae0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 2e9e5e4
> webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d8202a5
> webapp/src/main/java/org/apache/atlas/util/RestUtils.java 9d4b04e
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 4158f01
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6187cfb
>
> Diff: https://reviews.apache.org/r/56380/diff/
>
>
> Testing
> -------
>
> updated unit tests and verified that existing unit tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef
constraints and brought back legacy flags isComposite/reverseAttributeName
using constraints owner/inverseRef(attribute=attr1)
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164599
-----------------------------------------------------------
Ship it!
Just a few minor comments.
- Jeff Hagelberg
On Feb. 7, 2017, 10:55 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56380/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:55 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1526
> https://issues.apache.org/jira/browse/ATLAS-1526
>
>
> Repository: atlas
>
>
> Description
> -------
>
> constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 5ae16cf
> addons/models/0060-hbase_model.json 5febbbc
> addons/models/0080-storm_model.json 344227d
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 69cf60a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f507ae0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 2e9e5e4
> webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d8202a5
> webapp/src/main/java/org/apache/atlas/util/RestUtils.java 9d4b04e
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 4158f01
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6187cfb
>
> Diff: https://reviews.apache.org/r/56380/diff/
>
>
> Testing
> -------
>
> updated unit tests and verified that existing unit tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef
constraints and brought back legacy flags isComposite/reverseAttributeName
using constraints owner/inverseRef(attribute=attr1)
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Feb. 8, 2017, 12:42 a.m., Jeff Hagelberg wrote:
> > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, line 480
> > <https://reviews.apache.org/r/56380/diff/2/?file=1626955#file1626955line480>
> >
> > It looks like this these comments are now obsolete.
Good catch Jeff. I will update these comments in my next patch.
> On Feb. 8, 2017, 12:42 a.m., Jeff Hagelberg wrote:
> > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, line 479
> > <https://reviews.apache.org/r/56380/diff/2/?file=1626955#file1626955line479>
> >
> > Should this be an enumeration? I think that Jackson supports enumerations.
Enum would be a good idea. I will verify Jackson handling of enums and update in a separate patch.
> On Feb. 8, 2017, 12:42 a.m., Jeff Hagelberg wrote:
> > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, line 473
> > <https://reviews.apache.org/r/56380/diff/2/?file=1626955#file1626955line473>
> >
> > Could you add javadoc to document what these are and the semantics associated with them?
I think adding these details in twiki, along with new REST API details, might be a good option. I am working on this; should be done sometime next week.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164598
-----------------------------------------------------------
On Feb. 7, 2017, 10:55 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56380/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:55 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1526
> https://issues.apache.org/jira/browse/ATLAS-1526
>
>
> Repository: atlas
>
>
> Description
> -------
>
> constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 5ae16cf
> addons/models/0060-hbase_model.json 5febbbc
> addons/models/0080-storm_model.json 344227d
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 69cf60a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f507ae0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 2e9e5e4
> webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d8202a5
> webapp/src/main/java/org/apache/atlas/util/RestUtils.java 9d4b04e
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 4158f01
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6187cfb
>
> Diff: https://reviews.apache.org/r/56380/diff/
>
>
> Testing
> -------
>
> updated unit tests and verified that existing unit tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef
constraints and brought back legacy flags isComposite/reverseAttributeName
using constraints owner/inverseRef(attribute=attr1)
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164598
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java (line 471)
<https://reviews.apache.org/r/56380/#comment236364>
Could you add javadoc to document what these are and the semantics associated with them?
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java (line 475)
<https://reviews.apache.org/r/56380/#comment236366>
Should this be an enumeration? I think that Jackson supports enumerations.
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java (line 476)
<https://reviews.apache.org/r/56380/#comment236365>
It looks like this these comments are now obsolete.
- Jeff Hagelberg
On Feb. 7, 2017, 10:55 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56380/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:55 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1526
> https://issues.apache.org/jira/browse/ATLAS-1526
>
>
> Repository: atlas
>
>
> Description
> -------
>
> constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 5ae16cf
> addons/models/0060-hbase_model.json 5febbbc
> addons/models/0080-storm_model.json 344227d
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 69cf60a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f507ae0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 2e9e5e4
> webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d8202a5
> webapp/src/main/java/org/apache/atlas/util/RestUtils.java 9d4b04e
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 4158f01
> webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6187cfb
>
> Diff: https://reviews.apache.org/r/56380/diff/
>
>
> Testing
> -------
>
> updated unit tests and verified that existing unit tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef
constraints and brought back legacy flags isComposite/reverseAttributeName
using constraints owner/inverseRef(attribute=attr1)
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 10:55 p.m.)
Review request for atlas.
Changes
-------
updated patch after merge with latest master and addressing the review comments
Bugs: ATLAS-1526
https://issues.apache.org/jira/browse/ATLAS-1526
Repository: atlas
Description
-------
constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
Diffs (updated)
-----
addons/models/0030-hive_model.json 5ae16cf
addons/models/0060-hbase_model.json 5febbbc
addons/models/0080-storm_model.json 344227d
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93
intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa
intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 69cf60a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f507ae0
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 2e9e5e4
webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d8202a5
webapp/src/main/java/org/apache/atlas/util/RestUtils.java 9d4b04e
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java 4158f01
webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 6187cfb
Diff: https://reviews.apache.org/r/56380/diff/
Testing
-------
updated unit tests and verified that existing unit tests pass
Thanks,
Madhan Neethiraj
Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef
constraints and brought back legacy flags isComposite/reverseAttributeName
using constraints owner/inverseRef(attribute=attr1)
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Feb. 7, 2017, 5:55 p.m., Vimal Sharma wrote:
> > addons/models/0060-hbase_model.json, line 37
> > <https://reviews.apache.org/r/56380/diff/1/?file=1626416#file1626416line37>
> >
> > hbase_model.json is a placeholder for now, right?
> > I suggest we file a JIRA to revise the HBase model later
Vimal - hbase_model.json defines HBase types (table/column_family/column), which allow creation of entity instances of these types - via API or UI. This would allow users to add classifications to these instances - enabling classification-based authorization via Ranger.
> On Feb. 7, 2017, 5:55 p.m., Vimal Sharma wrote:
> > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java, line 150
> > <https://reviews.apache.org/r/56380/diff/1/?file=1626420#file1626420line150>
> >
> > Code in Line 115-125 and 127-137 is common.
> > Please move it outside the if check
Though currently all constraints are applicable for attributes of type 'entity', this need not be the case. Hence this seemingly duplicate code. These checks can be moved to a seprate method, to avoid code duplicate. I will address this in the next patch update.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164492
-----------------------------------------------------------
On Feb. 7, 2017, 11:06 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56380/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 11:06 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1526
> https://issues.apache.org/jira/browse/ATLAS-1526
>
>
> Repository: atlas
>
>
> Description
> -------
>
> constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 5ae16cf
> addons/models/0060-hbase_model.json 5febbbc
> addons/models/0080-storm_model.json 344227d
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java d48c87e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f507ae0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 2e9e5e4
> webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 1559eb9
> webapp/src/main/java/org/apache/atlas/util/RestUtils.java cecf636
>
> Diff: https://reviews.apache.org/r/56380/diff/
>
>
> Testing
> -------
>
> updated unit tests and verified that existing unit tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef
constraints and brought back legacy flags isComposite/reverseAttributeName
using constraints owner/inverseRef(attribute=attr1)
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164492
-----------------------------------------------------------
Fix it, then Ship it!
Rest looks good to me
addons/models/0060-hbase_model.json
<https://reviews.apache.org/r/56380/#comment236263>
hbase_model.json is a placeholder for now, right?
I suggest we file a JIRA to revise the HBase model later
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java (line 114)
<https://reviews.apache.org/r/56380/#comment236290>
Code in Line 115-125 and 127-137 is common.
Please move it outside the if check
- Vimal Sharma
On Feb. 7, 2017, 11:06 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56380/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 11:06 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1526
> https://issues.apache.org/jira/browse/ATLAS-1526
>
>
> Repository: atlas
>
>
> Description
> -------
>
> constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use cases of legacy flags isComposite/reverseAttributeName. Hence replace these constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 5ae16cf
> addons/models/0060-hbase_model.json 5febbbc
> addons/models/0080-storm_model.json 344227d
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2c00f54
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java d48c87e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f507ae0
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java 2e9e5e4
> webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 1559eb9
> webapp/src/main/java/org/apache/atlas/util/RestUtils.java cecf636
>
> Diff: https://reviews.apache.org/r/56380/diff/
>
>
> Testing
> -------
>
> updated unit tests and verified that existing unit tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>