You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/03/21 13:57:32 UTC
[GitHub] [maven-changes-plugin] elharo opened a new pull request #14: update
geronimo javamail
elharo opened a new pull request #14: update geronimo javamail
URL: https://github.com/apache/maven-changes-plugin/pull/14
@eolivelli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-changes-plugin] rmannibucau commented on issue #14: remove
geronimo javamail
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on issue #14: remove geronimo javamail
URL: https://github.com/apache/maven-changes-plugin/pull/14#issuecomment-602098553
Side note: they are still maintained (and dev to be complete). Advance conf can be sometimes different from javax.mail when not specified but works well. We should probably rather drop javax.mail and keep our impl only IMHO, would simplify reviews and licensing work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-changes-plugin] michael-o commented on issue #14: remove
geronimo javamail
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #14: remove geronimo javamail
URL: https://github.com/apache/maven-changes-plugin/pull/14#issuecomment-602084777
Is there any compile time code here?
What das `mvn dependency:analyze` say?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-changes-plugin] elharo commented on issue #14: remove
geronimo javamail
Posted by GitBox <gi...@apache.org>.
elharo commented on issue #14: remove geronimo javamail
URL: https://github.com/apache/maven-changes-plugin/pull/14#issuecomment-602059320
Tests pass: https://builds.apache.org/job/maven-box/job/maven-changes-plugin/job/mail/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-changes-plugin] rmannibucau edited a comment on issue #14:
remove geronimo javamail
Posted by GitBox <gi...@apache.org>.
rmannibucau edited a comment on issue #14: remove geronimo javamail
URL: https://github.com/apache/maven-changes-plugin/pull/14#issuecomment-602098553
Side note: they are still maintained (and dev to be complete). Advance conf can be sometimes different from javax.mail when not specified but works well. We should probably rather drop javax.mail and keep our impl only IMHO, would simplify reviews and licensing work.
Edit: no java 9 issue since maven does not run in apploader + we will likely add automatic module names when needed. That said the bundle dependency is preferred over individual modules which are not designed to be consummed like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-changes-plugin] elharo commented on issue #14: remove
geronimo javamail
Posted by GitBox <gi...@apache.org>.
elharo commented on issue #14: remove geronimo javamail
URL: https://github.com/apache/maven-changes-plugin/pull/14#issuecomment-602097034
Everything passes:
https://builds.apache.org/job/maven-box/job/maven-changes-plugin/job/mail/
At master:
```
[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ maven-changes-plugin ---
[WARNING] Used undeclared dependencies found:
[WARNING] org.apache.cxf:cxf-api:jar:2.6.3:compile
[WARNING] org.apache.xmlrpc:xmlrpc-common:jar:3.1.3:compile
[WARNING] org.sonatype.aether:aether-util:jar:1.13.1:compile
[WARNING] org.apache.maven:maven-settings-builder:jar:3.0.5:compile
[WARNING] javax.ws.rs:jsr311-api:jar:1.1.1:compile
[WARNING] org.codehaus.plexus:plexus-component-annotations:jar:1.7.1:compile
[WARNING] org.sonatype.sisu:sisu-inject-plexus:jar:2.3.0:compile
[WARNING] org.hamcrest:hamcrest-core:jar:1.3:test
[WARNING] org.apache.cxf:cxf-rt-transports-http:jar:2.6.3:compile
[WARNING] org.sonatype.aether:aether-impl:jar:1.13.1:compile
[WARNING] xml-apis:xml-apis:jar:1.3.04:compile
[WARNING] Unused declared dependencies found:
[WARNING] org.codehaus.plexus:plexus-interpolation:jar:1.24:compile
[WARNING] org.apache.geronimo.javamail:geronimo-javamail_1.4_provider:jar:1.7:compile
[WARNING] org.apache.geronimo.javamail:geronimo-javamail_1.4_mail:jar:1.7:compile
[WARNING] org.codehaus.plexus:plexus-mail-sender-javamail:jar:1.0-alpha-7:compile
[WARNING] org.codehaus.plexus:plexus-mail-sender-simple:jar:1.0-alpha-7:compile
[WARNING] commons-logging:commons-logging:jar:1.1.1:compile
[WARNING] org.apache.maven.doxia:doxia-module-xhtml:jar:1.4:compile
[WARNING] org.apache.httpcomponents:httpcore:jar:4.2.3:compile
[WARNING] org.apache.httpcomponents:httpclient:jar:4.2.3:compile
[WARNING] org.apache.maven:maven-compat:jar:3.0.5:test
[WARNING] org.sonatype.aether:aether-connector-wagon:jar:1.13.1:test
[WARNING] org.apache.maven.wagon:wagon-http:jar:2.4:test
```
and in this branch:
```
[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ maven-changes-plugin ---
[WARNING] Used undeclared dependencies found:
[WARNING] org.apache.cxf:cxf-api:jar:2.6.3:compile
[WARNING] org.apache.xmlrpc:xmlrpc-common:jar:3.1.3:compile
[WARNING] javax.mail:mail:jar:1.4:compile
[WARNING] org.sonatype.aether:aether-util:jar:1.13.1:compile
[WARNING] org.apache.maven:maven-settings-builder:jar:3.0.5:compile
[WARNING] javax.ws.rs:jsr311-api:jar:1.1.1:compile
[WARNING] org.codehaus.plexus:plexus-component-annotations:jar:1.7.1:compile
[WARNING] org.sonatype.sisu:sisu-inject-plexus:jar:2.3.0:compile
[WARNING] org.hamcrest:hamcrest-core:jar:1.3:test
[WARNING] org.apache.cxf:cxf-rt-transports-http:jar:2.6.3:compile
[WARNING] org.sonatype.aether:aether-impl:jar:1.13.1:compile
[WARNING] xml-apis:xml-apis:jar:1.3.04:compile
[WARNING] Unused declared dependencies found:
[WARNING] org.codehaus.plexus:plexus-interpolation:jar:1.24:compile
[WARNING] org.codehaus.plexus:plexus-mail-sender-javamail:jar:1.0-alpha-7:compile
[WARNING] org.codehaus.plexus:plexus-mail-sender-simple:jar:1.0-alpha-7:compile
[WARNING] commons-logging:commons-logging:jar:1.1.1:compile
[WARNING] org.apache.maven.doxia:doxia-module-xhtml:jar:1.4:compile
[WARNING] org.apache.httpcomponents:httpcore:jar:4.2.3:compile
[WARNING] org.apache.httpcomponents:httpclient:jar:4.2.3:compile
[WARNING] org.apache.maven:maven-compat:jar:3.0.5:test
[WARNING] org.sonatype.aether:aether-connector-wagon:jar:1.13.1:test
[WARNING] org.apache.maven.wagon:wagon-http:jar:2.4:test
```
Looks like there's a lot more cleanup left to do after this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-changes-plugin] elharo commented on issue #14: remove
geronimo javamail
Posted by GitBox <gi...@apache.org>.
elharo commented on issue #14: remove geronimo javamail
URL: https://github.com/apache/maven-changes-plugin/pull/14#issuecomment-602098107
This is not the only mail dependency we have. Indeed it is not the only dependency that provides some of these classes. Can you locate the place where we're using these particular artifacts? I could not.
These artifacts are quite old and don't seem to be actively maintained. Keeping them around seems risky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-changes-plugin] michael-o commented on issue #14: remove
geronimo javamail
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #14: remove geronimo javamail
URL: https://github.com/apache/maven-changes-plugin/pull/14#issuecomment-602097440
Here is the reason: https://maven.apache.org/plugins/maven-changes-plugin/examples/smtp-authentication.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services