You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2016/05/03 05:13:13 UTC

[jira] [Commented] (THRIFT-3795) Generated hashValue method in Swift will overflow

    [ https://issues.apache.org/jira/browse/THRIFT-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268007#comment-15268007 ] 

Hudson commented on THRIFT-3795:
--------------------------------

SUCCESS: Integrated in Thrift-precommit #451 (See [https://builds.apache.org/job/Thrift-precommit/451/])
THRIFT-3795 Generated hashValue method in Swift will overflow Client: (jensg: [https://github.com/apache/thrift/commit/80542987f96febd5182072b6ce32ffcc1d43eab7])
* compiler/cpp/src/generate/t_swift_generator.cc


> Generated hashValue method in Swift will overflow
> -------------------------------------------------
>
>                 Key: THRIFT-3795
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3795
>             Project: Thrift
>          Issue Type: Bug
>          Components: Swift - Compiler
>    Affects Versions: 0.9.3
>            Reporter: Håkon Hitland
>            Assignee: Håkon Hitland
>            Priority: Minor
>             Fix For: 0.10.0
>
>         Attachments: overflow.patch
>
>
> The generated hashValue code for Swift uses the + and * arithmetic operators, for which an overflow is a fatal error.
> The intention is probably to wrap around, so the overflow operators should be used instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)