You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Manu Zhang (JIRA)" <ji...@apache.org> on 2016/10/24 05:34:58 UTC

[jira] [Commented] (BEAM-800) DoFnLifeCycleManager should hold DoFnInvoker, not DoFn/OldDoFn

    [ https://issues.apache.org/jira/browse/BEAM-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601003#comment-15601003 ] 

Manu Zhang commented on BEAM-800:
---------------------------------

Could you link where {{OldDoFn}} being ported to {{DoFn}} happens ? Is this blocked by the porting ?

> DoFnLifeCycleManager should hold DoFnInvoker, not DoFn/OldDoFn
> --------------------------------------------------------------
>
>                 Key: BEAM-800
>                 URL: https://issues.apache.org/jira/browse/BEAM-800
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Kenneth Knowles
>            Priority: Minor
>
> The {{DirectRunner}}'s support class {{DoFnLifecycleManager}} holds a cache of deserialized {{OldDoFn}} s, now being ported to {{DoFn}} s. But to execute a {{DoFn}} there is another layer of indirection through a {{DoFnInvoker}}, which is the best object to cache here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)