You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/17 15:16:11 UTC

[GitHub] [openwhisk-composer] dylandepass opened a new pull request #70: Fixed bug when using boolean value annotations with deploy

dylandepass opened a new pull request #70: Fixed bug when using boolean value annotations with deploy
URL: https://github.com/apache/openwhisk-composer/pull/70
 
 
   Currently if you try and use a boolean valued annotation with the deploy command the value is treated as a string and not a boolean. 
   
   For example
   ```
   deploy aio-tests-0.0.1/test-composer actions/test-composer/index.json -w --annotation web-export=true 
   ```
   
   Results in the web-export being set to 'true' and not the boolean value true. The web-export annotation does not work if the value is set to 'true'
   
   ![Screen Shot 2020-03-17 at 11 14 43 AM](https://user-images.githubusercontent.com/3231084/76870771-84987100-6840-11ea-8f91-a6460f86c1b6.png)
   
   This PR attempts to fix that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-composer] dylandepass commented on a change in pull request #70: Fixed bug when using boolean value annotations with deploy

Posted by GitBox <gi...@apache.org>.
dylandepass commented on a change in pull request #70: Fixed bug when using boolean value annotations with deploy
URL: https://github.com/apache/openwhisk-composer/pull/70#discussion_r393776311
 
 

 ##########
 File path: bin/deploy.js
 ##########
 @@ -73,7 +73,8 @@ try {
   for (let annotation of [...(argv.annotation || [])]) {
     const index = annotation.indexOf('=')
     if (index < 0) throw Error('Annotation syntax must be "KEY=VALUE"')
-    composition.annotations.push({ key: annotation.substring(0, index), value: annotation.substring(index + 1) })
+    const value = annotation.substring(index + 1);
 
 Review comment:
   PR Updated, thanks @rabbah 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk-composer] rabbah commented on a change in pull request #70: Fixed bug when using boolean value annotations with deploy

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #70: Fixed bug when using boolean value annotations with deploy
URL: https://github.com/apache/openwhisk-composer/pull/70#discussion_r393769599
 
 

 ##########
 File path: bin/deploy.js
 ##########
 @@ -73,7 +73,8 @@ try {
   for (let annotation of [...(argv.annotation || [])]) {
     const index = annotation.indexOf('=')
     if (index < 0) throw Error('Annotation syntax must be "KEY=VALUE"')
-    composition.annotations.push({ key: annotation.substring(0, index), value: annotation.substring(index + 1) })
+    const value = annotation.substring(index + 1);
 
 Review comment:
   ```suggestion
       const value = annotation.substring(index + 1).toLowerCase();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services