You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/05 16:26:35 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #6879: Close producer when the topic does not exists.

codelipenghui opened a new pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879


   Fixes #6838
   
   ### Motivation
   
   Close producer when the topic does not exists.
   
   ### Modifications
   
   1. Fix exception handle for the topic does not exist.
   2. Change state to Close when producer got TopicDoesNotExists exception so that the producer can close the cnx and will no longer add send timeout tasks to HashedWheelTimer.
   
   ### Verifying this change
   
   New unit tests added.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-626269396


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-626256261


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-625306025


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-625829045


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-626262113


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-625055430


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-624679433


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-626446183


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] jiazhai commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-625602433


   /pulsarbot run-failure-checks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #6879: Close producer when the topic does not exists.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6879:
URL: https://github.com/apache/pulsar/pull/6879#issuecomment-626176539


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org