You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/30 07:41:35 UTC
[GitHub] [spark] dcoliversun opened a new pull request, #39306: [WIP][SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
dcoliversun opened a new pull request, #39306:
URL: https://github.com/apache/spark/pull/39306
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #39306: [SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by "dcoliversun (via GitHub)" <gi...@apache.org>.
dcoliversun commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1414710633
gentle ping @dongjoon-hyun :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #39306: [WIP][SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1369305521
@dongjoon-hyun Sorry for my late reply. I'm working on minimize intrusive code :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #39306: [WIP][SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1368131349
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cometta commented on pull request #39306: [SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by "cometta (via GitHub)" <gi...@apache.org>.
cometta commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1528620859
on spark 3.3 i able to shared the same PVC for driver and executors but in spark 3.4 , i get error `should contain OnDemand or SPARK_EXECUTOR_ID when requiring multiple executors`. is this related to this ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #39306: [SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by "dcoliversun (via GitHub)" <gi...@apache.org>.
dcoliversun commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1533976855
@cometta Hi, this PR is not related to the problem you're having. Could you create an issue in JIRA, attach your spark configuration? I will follow up :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #39306: [WIP][SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1369324290
@dongjoon-hyun
I'd like to discuss two options with you :)
* First: Refer to the idea of [SPARK-37331](https://issues.apache.org/jira/browse/SPARK-37331), I try to move PVC from resources to pre-resources, and set up before driver and executor creation. In future, we could set ConfigMap as pre-resource because there is same warn information about resource not found from k8s scheduler. (This is how this PR works.)
* Second: Leave PVC as resource, filter PVC from resources and setup it before pod creation.
I prefer the first option. First option has more scalability, we could set other k8s resource as pre-resource if need. And I agree with you about code intrusiveness. I think it's worth setting PVC as pre-resource.
Any suggestion is greatly appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #39306: [SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1383707298
@dongjoon-hyun
> According to the updated PR description, is the only benefit of this refactoring is to remove warning K8s event messages?
This PR brings two benefit:
* Remove unnecessary warning k8s event messages. We collect events as alarms, and it is currently impossible to determine whether this event is caused by insufficient storage resources or resource creation order.
* In some schedule scenarios, the problem that webhook cannot find PVC based on Pod Spec can be fixed, because old logic is to create PVC after Pod creation.
> Does this PR work with the existing feature like [SPARK-41515](https://issues.apache.org/jira/browse/SPARK-41515) ?
I'm working on it. Let me check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #39306: [SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by "dcoliversun (via GitHub)" <gi...@apache.org>.
dcoliversun commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1399216750
Thank you for the reviews @dongjoon-hyun , I believe I've addressed your comments! Tomorrow is also the Chinese New Year, I wish you a happy Chinese New Year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun closed pull request #39306: [SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by "dcoliversun (via GitHub)" <gi...@apache.org>.
dcoliversun closed pull request #39306: [SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
URL: https://github.com/apache/spark/pull/39306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cometta commented on pull request #39306: [SPARK-41781][K8S] Add the ability to create pvc before creating driver/executor pod
Posted by "cometta (via GitHub)" <gi...@apache.org>.
cometta commented on PR #39306:
URL: https://github.com/apache/spark/pull/39306#issuecomment-1534700514
@dcoliversun created jira ticket https://issues.apache.org/jira/browse/SPARK-43329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org