MENFORCER-117, 1.2 release and -1 vote

[Barrie Treloar <ba...@gmail.com>]

On Fri, Jul 6, 2012 at 6:49 PM, Nord, James <JN...@nds.com> wrote:
> -1 non binding
>
> MENFORCER-117 is not fixed as although the site links to the page now - the page is useless (it is a cut and paste of requiredPLugin versions with only the title changed).
>
> <snip file="requireNoRepositories.apt.vm">
> Require No Repositories
>
>    This rule enforces that all plugins have a version defined, either in the plugin or pluginManagement section of the pom or a parent pom.
> </snip>

I dont understand what you are saying.

MENFORCER-117 doesn't change anything external for the plugin.
It just fixed errors when you have any plugins that have extensions
and additions to the lifecycle.

Can you please explain what the problem is?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

RE: MENFORCER-117, 1.2 release and -1 vote

["Nord, James" <JN...@nds.com>]

> On Fri, Jul 6, 2012 at 6:49 PM, Nord, James <JN...@nds.com> wrote:
> > -1 non binding
> >
> > MENFORCER-117 is not fixed as although the site links to the page now - the
> page is useless (it is a cut and paste of requiredPLugin versions with only the
> title changed).
> >
> > <snip file="requireNoRepositories.apt.vm">
> > Require No Repositories
> >
> >    This rule enforces that all plugins have a version defined, either in the
> plugin or pluginManagement section of the pom or a parent pom.
> > </snip>
>
> I dont understand what you are saying.
>
> MENFORCER-117 doesn't change anything external for the plugin.
> It just fixed errors when you have any plugins that have extensions and
> additions to the lifecycle.
>
> Can you please explain what the problem is?

I pasted the wrong JIRA - my mistake.
It should have been the following :
        [MENFORCER-132] - Add missing rules to standard rules page and reorder them

The patch for that added a link for requireNoRepositories to index.apt
         {{{./requireNoRepositories.html}requireNoRepositories}} - enforces to not include repositories.

However if you take a look at the requireNoRepositories.apt.vm file then you can see it is almost an exact duplicate of the requiredPluginVersions page (down to the configuration parameters!).
(see http://svn.apache.org/viewvc/maven/enforcer/trunk/enforcer-rules/src/site/apt/requireNoRepositories.apt.vm?view=markup and ignore line 26 which seems to be the only correct line!)

Incorrect documentation is worse than no documentation (IMHO).

/James


**************************************************************************************
This message is confidential and intended only for the addressee. If you have received this message in error, please immediately notify the postmaster@nds.com and delete it from your system as well as any copies. The content of e-mails as well as traffic data may be monitored by NDS for employment and security purposes. To protect the environment please do not print this e-mail unless necessary.

NDS Limited. Registered Office: One London Road, Staines, Middlesex, TW18 4EX, United Kingdom. A company registered in England and Wales. Registered no. 3080780. VAT no. GB 603 8808 40-00
**************************************************************************************

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org