You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/04 11:14:52 UTC

[GitHub] kakoni commented on a change in pull request #5802: Simpifying docker contrib

kakoni commented on a change in pull request #5802: Simpifying docker contrib
URL: https://github.com/apache/incubator-superset/pull/5802#discussion_r214875854
 
 

 ##########
 File path: contrib/docker/docker-entrypoint.sh
 ##########
 @@ -5,6 +5,10 @@ if [ "$#" -ne 0 ]; then
     exec "$@"
 elif [ "$SUPERSET_ENV" = "local" ]; then
     superset runserver -d
+elif [ "$SUPERSET_ENV" = "development" ]; then
+    superset runserver -d &
+    cd /home/work/incubator-superset/superset/assets
 
 Review comment:
   Oh yes.  See
   https://github.com/apache/incubator-superset/blob/master/contrib/docker/Dockerfile#L11
   https://github.com/apache/incubator-superset/blob/master/contrib/docker/Dockerfile#L32-L34
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org