You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/04/27 06:57:25 UTC
Review Request 46724: Added test to ensure calls from disconnected
scheduler are dropped.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46724/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-5181
https://issues.apache.org/jira/browse/MESOS-5181
Repository: mesos
Description
-------
This change adds a test that ensures that the scheduler receives
an error message for all subsequent calls after the master marks
it as disconnected.
Diffs
-----
src/tests/partition_tests.cpp 4ee7f03c7db4fb6cf5b9130de4e03d24100161d1
Diff: https://reviews.apache.org/r/46724/diff/
Testing
-------
gtest_repeat=100
Thanks,
Anand Mazumdar
Re: Review Request 46724: Added test to ensure calls from disconnected
scheduler are dropped.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46724/#review130826
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/partition_tests.cpp (lines 651 - 653)
<https://reviews.apache.org/r/46724/#comment194728>
After you update the previous review, you no longer would need this.
- Vinod Kone
On April 27, 2016, 4:57 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46724/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 4:57 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-5181
> https://issues.apache.org/jira/browse/MESOS-5181
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds a test that ensures that the scheduler receives
> an error message for all subsequent calls after the master marks
> it as disconnected.
>
>
> Diffs
> -----
>
> src/tests/partition_tests.cpp 4ee7f03c7db4fb6cf5b9130de4e03d24100161d1
>
> Diff: https://reviews.apache.org/r/46724/diff/
>
>
> Testing
> -------
>
> gtest_repeat=100
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 46724: Added test to ensure calls from disconnected
scheduler are dropped.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46724/#review130968
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 27, 2016, 11:36 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46724/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 11:36 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-5181
> https://issues.apache.org/jira/browse/MESOS-5181
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds a test that ensures that the scheduler receives
> an error message for all subsequent calls after the master marks
> it as disconnected.
>
>
> Diffs
> -----
>
> src/tests/partition_tests.cpp 4ee7f03c7db4fb6cf5b9130de4e03d24100161d1
>
> Diff: https://reviews.apache.org/r/46724/diff/
>
>
> Testing
> -------
>
> gtest_repeat=100
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 46724: Added test to ensure calls from disconnected
scheduler are dropped.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46724/#review130872
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46721, 46722, 46723, 46724]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 27, 2016, 11:36 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46724/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 11:36 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-5181
> https://issues.apache.org/jira/browse/MESOS-5181
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds a test that ensures that the scheduler receives
> an error message for all subsequent calls after the master marks
> it as disconnected.
>
>
> Diffs
> -----
>
> src/tests/partition_tests.cpp 4ee7f03c7db4fb6cf5b9130de4e03d24100161d1
>
> Diff: https://reviews.apache.org/r/46724/diff/
>
>
> Testing
> -------
>
> gtest_repeat=100
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 46724: Added test to ensure calls from disconnected
scheduler are dropped.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46724/
-----------------------------------------------------------
(Updated April 27, 2016, 11:36 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments from Vinod
Bugs: MESOS-5181
https://issues.apache.org/jira/browse/MESOS-5181
Repository: mesos
Description
-------
This change adds a test that ensures that the scheduler receives
an error message for all subsequent calls after the master marks
it as disconnected.
Diffs (updated)
-----
src/tests/partition_tests.cpp 4ee7f03c7db4fb6cf5b9130de4e03d24100161d1
Diff: https://reviews.apache.org/r/46724/diff/
Testing
-------
gtest_repeat=100
Thanks,
Anand Mazumdar
Re: Review Request 46724: Added test to ensure calls from disconnected
scheduler are dropped.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46724/#review130729
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46721, 46722, 46723, 46724]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 27, 2016, 4:57 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46724/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 4:57 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-5181
> https://issues.apache.org/jira/browse/MESOS-5181
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds a test that ensures that the scheduler receives
> an error message for all subsequent calls after the master marks
> it as disconnected.
>
>
> Diffs
> -----
>
> src/tests/partition_tests.cpp 4ee7f03c7db4fb6cf5b9130de4e03d24100161d1
>
> Diff: https://reviews.apache.org/r/46724/diff/
>
>
> Testing
> -------
>
> gtest_repeat=100
>
>
> Thanks,
>
> Anand Mazumdar
>
>