You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by Todd Volkert <tv...@gmail.com> on 2009/05/29 20:24:44 UTC
[VOTE] Release Pivot 1.2 RC2
All:
The Pivot 1.2 RC2 release candidate has been tagged, packaged, and is
ready for a vote. The artifacts, RAT reports, KEYS file, and release
notes can be found at
http://people.apache.org/~tvolkert/dist/pivot/v1.2-rc2/. The tag from
which the release artifacts were generated can be found at
http://svn.apache.org/repos/asf/incubator/pivot/tags/v1.2-rc2/.
In addition, my PGP public code signing key can be found at the MIT
key server (http://pgp.mit.edu/) and The SKS key server
(http://www.pramberger.at/peter/services/keyserver/).
Notes that the JUnit tests included in the source distribution are
compiled as part of the build process but are not automatically run
(the same was true of the 1.1 release). This will be addressed in the
1.3 release (see PIVOT-131).
Please vote to publish this release by Monday, June 1 20:00 GMT. In
so doing, please include the testing you performed to arrive at your
vote.
[ ] +1 Publish
[ ] +0
[ ] -0
[ ] -1 Don't publish (specify why)
Upon a positive majority of binding votes, the results of this vote
will be brought to the Incubator PMC and voted upon there.
Thanks,
-T
Re: [VOTE] Release Pivot 1.2 RC2
Posted by Greg Brown <gk...@mac.com>.
+1. Here's what I did:
- Downloaded:
apache-pivot-1.2-incubating-src.tar.gz
apache-pivot-1.2-incubating-src.tar.gz.md5
apache-pivot-1.2-incubating.tar.gz
apache-pivot-1.2-incubating.tar.gz.md5
- Verified checksums
- Uncompressed downloaded archives
- Ran install target on downloaded source
- Copied StAX JARs to generated lib directory
- Verified execution of Kitchen Sink demo in a web browser
- Removed "-incubating" from all JARs in binary distribution lib directory
- Copied StAX JARs to binary lib directory
- Copied built demos and tutorials JARs to binary lib directory
- Verified execution of Kitchen Sink demo in a web browser
- Reviewed decompressed artifact contents
- Reviewed release documents
On Friday, May 29, 2009, at 02:24PM, "Todd Volkert" <tv...@gmail.com> wrote:
>All:
>
>The Pivot 1.2 RC2 release candidate has been tagged, packaged, and is
>ready for a vote. The artifacts, RAT reports, KEYS file, and release
>notes can be found at
>http://people.apache.org/~tvolkert/dist/pivot/v1.2-rc2/. The tag from
>which the release artifacts were generated can be found at
>http://svn.apache.org/repos/asf/incubator/pivot/tags/v1.2-rc2/.
>
>In addition, my PGP public code signing key can be found at the MIT
>key server (http://pgp.mit.edu/) and The SKS key server
>(http://www.pramberger.at/peter/services/keyserver/).
>
>Notes that the JUnit tests included in the source distribution are
>compiled as part of the build process but are not automatically run
>(the same was true of the 1.1 release). This will be addressed in the
>1.3 release (see PIVOT-131).
>
>Please vote to publish this release by Monday, June 1 20:00 GMT. In
>so doing, please include the testing you performed to arrive at your
>vote.
>
>[ ] +1 Publish
>[ ] +0
>[ ] -0
>[ ] -1 Don't publish (specify why)
>
>Upon a positive majority of binding votes, the results of this vote
>will be brought to the Incubator PMC and voted upon there.
>
>Thanks,
>-T
>
>
Re: [VOTE] Release Pivot 1.2 RC2
Posted by Sandro Martini <sa...@gmail.com>.
Hi to all,
cause Holidays, I'll test the new release Wednesday and then I'll send
my vote during the day.
Bye,
Sandro
Re: [VOTE] Release Pivot 1.2 RC2
Posted by Todd Volkert <tv...@gmail.com>.
In light of this vote having spanned the weekend and today being a public
holiday in some countries, the deadline for this vote is being extended to
Wednesday, June 3.
Cheers,
-T
Re: [VOTE] Release Pivot 1.2 RC2
Posted by Todd Volkert <tv...@gmail.com>.
>
> - ant tasks: ant, ant clean, ant doc
>
> I've seen that the doc task is not dependent to a build task like package,
> so running an ant clean and then ant doc generates nothing of JavaDoc
> files.
> After fixing it, i got 2 Javadoc errors, and no files are generated:
> [javadoc] javadoc: error - Illegal package name: "src=' + gaJsHost +
> google-analytics.com/ga.js'"
> [javadoc] javadoc: error - Illegal package name:
> "type='text/javascript'%3E%3C/script%3E));
>
>
> I've seen that ant install cleans the doc subdirectory,
> then the docs subdirectory under install/apache-pivot-1.2-incubating
> is empty too,
> so it isn't put inside the generated zip and tar.gz
Weird - the doc target works fine for me, otherwise I wouldn't have been
able to generate the artifacts. It generates the docs under the "doc"
folder, and the Google Analytics code shouldn't show up as doc errors. What
OS, JDK, and Ant version are you using?
Target demos is not dependent on a build task (or for example from
> tutorials),
> while the Tutorials task is Ok.
> Target demos-package depends on build instead of demos.
Good catch. I've fixed this on the trunk, but I agree that this is minor.
> - ant tasks: ant dist is Ok. ant install
> - ant tasks: ant install
> As seen in the ant doc, the doc is not generated, so it isn't copied
> inside the install/doc and then zipped
Yeah, if the doc target doesn't work properly for you, then the install
target won't either, but the source of this problem is the doc target. \
- and the two stax jars aren't copied to the lib subdir, so i have to
> copy into the lib
The stax jars that are checked into SVN are the modified versions, so
there's no need to package anything in the "package" target, and that's why
they're not packaged into the lib folder in the package target. They're
simply copied to the install lib folder in the install target.
> I have to copy inside the lib dir also the pivot-tutorials.jar and
> pivot-demos.jar, generated from source distribution, is this ok ?
Yeah, we've consciously chosen for the 1.1 and this release to exclude the
tutorials and demos jars from the binary distribution. We plan to include
these in later releases, but only after we have a better way to provide them
(like a set of HTML files with an index file that the user can open in their
browser to see the demos easily).
> And
> also the pivot-wtk.obsidian.jar is missing from there, again is it ok
> ?
Yeah, this theme is only a proof of concept for theming and is not nearly
ready for prime-time yet, so it's not included in the binary distribution.
> Only one question, on our custom StAX distribution: isn't it dangerous ?
> This isn't a real problem, but if someone use/has to use the original
> StAX jar what can happen ?
It's not dangerous - it's a performance optimization that's documented in
the README file. If the user uses a different stax implementation, they'll
get correct behavior but may get unnecessary codebase lookups. See the
README for more info.
A hint:
> why not put inside zip/tar.gz also a sample script (.bat and .sh) to
> run some tutorials and demos from generated jars in a simple way ?
Yeah, we may do this at the same time we add the HTML files such that we can
deploy those jars with our release with the appropriate context. This'll be
for a future release.
Thanks for the thorough review Sandro!
-T
Re: [VOTE] Release Pivot 1.2 RC2
Posted by Greg Brown <gk...@mac.com>.
>- in README i've seen this:
>
>* Pivot's charting components require a compatible chart provider. No such
> provider is included in this release, but one is available here:
>
> http://code.google.com/p/pivot-jfree/
>
> Version 1.1 of this provider is compatible with Pivot 1.2. Please note that
> this provider has a dependency on JFreeChart, which is licensed under LGPL.
>
>but the jar is only at version 1.0, is it right ?
Yes - we'll generate the 1.1 JAR when Pivot 1.2 is final.
Re: [VOTE] Release Pivot 1.2 RC2
Posted by Sandro Martini <sa...@gmail.com>.
Hi to all,
Test done in my environment (Windows XP SP3 + Jdk 6u12 + Internet
Explorer 6 + Firefox 3.0.10):
- checked md5 of apache-pivot-1.2-incubating.zip and
apache-pivot-1.2-incubating-src.zip
- reviewed decompressed artifact contents
- inspected source RAT reports
- review root files (README, BUILD, etc)
- in README i've seen this:
* Pivot's charting components require a compatible chart provider. No such
provider is included in this release, but one is available here:
http://code.google.com/p/pivot-jfree/
Version 1.1 of this provider is compatible with Pivot 1.2. Please note that
this provider has a dependency on JFreeChart, which is licensed under LGPL.
but the jar is only at version 1.0, is it right ?
- ant tasks: ant, ant clean, ant doc
I've seen that the doc task is not dependent to a build task like package,
so running an ant clean and then ant doc generates nothing of JavaDoc files.
After fixing it, i got 2 Javadoc errors, and no files are generated:
[javadoc] javadoc: error - Illegal package name: "src=' + gaJsHost +
google-analytics.com/ga.js'"
[javadoc] javadoc: error - Illegal package name:
"type='text/javascript'%3E%3C/script%3E));
I've seen that ant install cleans the doc subdirectory,
then the docs subdirectory under install/apache-pivot-1.2-incubating
is empty too,
so it isn't put inside the generated zip and tar.gz
Target demos is not dependent on a build task (or for example from tutorials),
while the Tutorials task is Ok.
Target demos-package depends on build instead of demos.
- ant tasks: ant dist is Ok. ant install
- ant tasks: ant install
As seen in the ant doc, the doc is not generated, so it isn't copied
inside the install/doc and then zipped
Someone had some of these things ?
- and the two stax jars aren't copied to the lib subdir, so i have to
copy into the lib
- set the CLASSPATH environment for my run tests, and then run some
tutorials and some demos as Applications, like:
java pivot.wtk.DesktopApplicationContext pivot.tutorials.Demo
java pivot.wtk.DesktopApplicationContext
pivot.tutorials.stocktracker.StockTracker
java pivot.wtk.DesktopApplicationContext pivot.demos.clock.Demo
java pivot.wtk.DesktopApplicationContext pivot.demos.roweditor.Demo
Then, tried to execute the same applications also from the binary zip,
so before i have to rename the jars removing the -incubating, and then
all works good.
I have to copy inside the lib dir also the pivot-tutorials.jar and
pivot-demos.jar, generated from source distribution, is this ok ? And
also the pivot-wtk.obsidian.jar is missing from there, again is it ok
?
Only one question, on our custom StAX distribution: isn't it dangerous ?
This isn't a real problem, but if someone use/has to use the original
StAX jar what can happen ?
In any case, my vote is +0.5, i don't think the problems with the doc
are blocking, and task dependencies too, and also the missing jars
from the binary (but i'd like to have these, should be useful to our
users).
A hint:
why not put inside zip/tar.gz also a sample script (.bat and .sh) to
run some tutorials and demos from generated jars in a simple way ?
Thanks and bye,
Sandro
Re: [VOTE] Release Pivot 1.2 RC2
Posted by Martijn Dashorst <ma...@gmail.com>.
+1 (just looked through the RAT report, and the structure looks ok, no
strange files)
Martijn
On Fri, May 29, 2009 at 8:24 PM, Todd Volkert <tv...@gmail.com> wrote:
> All:
>
> The Pivot 1.2 RC2 release candidate has been tagged, packaged, and is
> ready for a vote. The artifacts, RAT reports, KEYS file, and release
> notes can be found at
> http://people.apache.org/~tvolkert/dist/pivot/v1.2-rc2/. The tag from
> which the release artifacts were generated can be found at
> http://svn.apache.org/repos/asf/incubator/pivot/tags/v1.2-rc2/.
>
> In addition, my PGP public code signing key can be found at the MIT
> key server (http://pgp.mit.edu/) and The SKS key server
> (http://www.pramberger.at/peter/services/keyserver/).
>
> Notes that the JUnit tests included in the source distribution are
> compiled as part of the build process but are not automatically run
> (the same was true of the 1.1 release). This will be addressed in the
> 1.3 release (see PIVOT-131).
>
> Please vote to publish this release by Monday, June 1 20:00 GMT. In
> so doing, please include the testing you performed to arrive at your
> vote.
>
> [ ] +1 Publish
> [ ] +0
> [ ] -0
> [ ] -1 Don't publish (specify why)
>
> Upon a positive majority of binding votes, the results of this vote
> will be brought to the Incubator PMC and voted upon there.
>
> Thanks,
> -T
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Apache Wicket 1.3.5 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.
Re: [VOTE] Release Pivot 1.2 RC2
Posted by Christopher Brind <br...@brindy.org.uk>.
+1
The following was done using Mac OS and this version of Java:
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Downloaded:
apache-pivot-1.2-incubating-src.tar.gz
apache-pivot-1.2-incubating-src.tar.gz.sha
apache-pivot-1.2-incubating.tar.gz
apache-pivot-1.2-incubating.tar.gz.sha
apache-pivot-1.2-incubating.zip
apache-pivot-1.2-incubating.zip.sha
apache-pivot-1.2-incubating-src.zip
apache-pivot-1.2-incubating-src.zip.sha
Verified all checksums visually by running `openssl sha1 <filename>` and
comparing against the appropriate sha.
Unzipped apache-pivot-1.2-incubating-src.zip
Ran install target.
Copied stax jars to lib directory.
Ran the following demos by copying the pivot.web's HTML
(src/pivot/web/www/index.html) page and editing the applet tag:
- clock
- decorator
- row editor
Copied the index.html from previous step and the copied the pivot-demos.jar
to the install lib folder and ran following demos against the incubator
jars:
- clock
- decorator
- row editor
- fixed column tables
Cheers,
Chris
2009/5/29 Todd Volkert <tv...@gmail.com>
> All:
>
> The Pivot 1.2 RC2 release candidate has been tagged, packaged, and is
> ready for a vote. The artifacts, RAT reports, KEYS file, and release
> notes can be found at
> http://people.apache.org/~tvolkert/dist/pivot/v1.2-rc2/<http://people.apache.org/%7Etvolkert/dist/pivot/v1.2-rc2/>.
> The tag from
> which the release artifacts were generated can be found at
> http://svn.apache.org/repos/asf/incubator/pivot/tags/v1.2-rc2/.
>
> In addition, my PGP public code signing key can be found at the MIT
> key server (http://pgp.mit.edu/) and The SKS key server
> (http://www.pramberger.at/peter/services/keyserver/).
>
> Notes that the JUnit tests included in the source distribution are
> compiled as part of the build process but are not automatically run
> (the same was true of the 1.1 release). This will be addressed in the
> 1.3 release (see PIVOT-131).
>
> Please vote to publish this release by Monday, June 1 20:00 GMT. In
> so doing, please include the testing you performed to arrive at your
> vote.
>
> [ ] +1 Publish
> [ ] +0
> [ ] -0
> [ ] -1 Don't publish (specify why)
>
> Upon a positive majority of binding votes, the results of this vote
> will be brought to the Incubator PMC and voted upon there.
>
> Thanks,
> -T
>
Re: [VOTE] Release Pivot 1.2 RC2
Posted by Todd Volkert <tv...@gmail.com>.
+1
Here's what I tested:
- Verified all MD5, SHA, and PGP signatures against the artifacts
- Verified that the contents of the tar.gz artifacts matched that of the
zip artifacts
- Verified that the contents of the source distribution matched that of
the SVN tag exactly
- Verified that the source distribution compiles against the following
environments:
- Linux x64 - Sun JDK 1.6
- Linux x64 - Sun JDK 1.7
- Linux x64 - OpenJDK 1.6
- Windows x86 - Sun JDK 1.6
- Inspected source and binary distribution RAT reports:
- Checked that all files were properly licensed
- Checked that all non-Pivot jars were covered by the NOTICE file
- Ran some sample applications against the binary distribution
- The HTTPClient included in the tools jar
- The tutorial demo on my local system
- Browsed the Javadocs in the binary distribution
- Tried to build against JDK1.5 to verify proper failure
- Verified that the issues brought up with the RC1 candidate have been
fixed
- The README and RELEASE-NOTES have been updated
- The project folder is no longer included in the release
-T
On Fri, May 29, 2009 at 2:24 PM, Todd Volkert <tv...@gmail.com> wrote:
> All:
>
> The Pivot 1.2 RC2 release candidate has been tagged, packaged, and is
> ready for a vote. The artifacts, RAT reports, KEYS file, and release
> notes can be found at
> http://people.apache.org/~tvolkert/dist/pivot/v1.2-rc2/. The tag from
> which the release artifacts were generated can be found at
> http://svn.apache.org/repos/asf/incubator/pivot/tags/v1.2-rc2/.
>
> In addition, my PGP public code signing key can be found at the MIT
> key server (http://pgp.mit.edu/) and The SKS key server
> (http://www.pramberger.at/peter/services/keyserver/).
>
> Notes that the JUnit tests included in the source distribution are
> compiled as part of the build process but are not automatically run
> (the same was true of the 1.1 release). This will be addressed in the
> 1.3 release (see PIVOT-131).
>
> Please vote to publish this release by Monday, June 1 20:00 GMT. In
> so doing, please include the testing you performed to arrive at your
> vote.
>
> [ ] +1 Publish
> [ ] +0
> [ ] -0
> [ ] -1 Don't publish (specify why)
>
> Upon a positive majority of binding votes, the results of this vote
> will be brought to the Incubator PMC and voted upon there.
>
> Thanks,
> -T
>