You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@htrace.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2015/06/11 23:39:00 UTC

[jira] [Commented] (HTRACE-177) htrace-zipkin: shade all dependencies

    [ https://issues.apache.org/jira/browse/HTRACE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582549#comment-14582549 ] 

Colin Patrick McCabe commented on HTRACE-177:
---------------------------------------------

Thanks, [~Longinus00].  I verified that this built and passed all unit tests.  I also checked via "jar tvf" that the dependencies are now shaded.  Good work.  +1.

> htrace-zipkin: shade all dependencies
> -------------------------------------
>
>                 Key: HTRACE-177
>                 URL: https://issues.apache.org/jira/browse/HTRACE-177
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: Daniel Lee
>              Labels: patch
>         Attachments: 0001-fix-shading-issue.patch
>
>
> Currently org.slf4j, org.apache.commons and org.apache.http aren't being shaded and are subsequently leaking into the global CLASSPATH. This also means that a dependency for a slf4j implementation will need to be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)