You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by ri...@apache.org on 2008/06/03 13:37:37 UTC
svn commit: r662748 -
/geronimo/server/trunk/plugins/javamail/javamail/pom.xml
Author: rickmcguire
Date: Tue Jun 3 04:37:37 2008
New Revision: 662748
URL: http://svn.apache.org/viewvc?rev=662748&view=rev
Log:
GERONIMO-4096 Remove PortOffset from SMTPPort definition.
Modified:
geronimo/server/trunk/plugins/javamail/javamail/pom.xml
Modified: geronimo/server/trunk/plugins/javamail/javamail/pom.xml
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/javamail/javamail/pom.xml?rev=662748&r1=662747&r2=662748&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/javamail/javamail/pom.xml (original)
+++ geronimo/server/trunk/plugins/javamail/javamail/pom.xml Tue Jun 3 04:37:37 2008
@@ -79,7 +79,7 @@
<config-xml-content>
<gbean name="SMTPTransport">
<attribute name="host">${SMTPHost}</attribute>
- <attribute name="port">${SMTPPort + PortOffset}</attribute>
+ <attribute name="port">${SMTPPort}</attribute>
</gbean>
</config-xml-content>
<config-substitution key="SMTPHost">localhost</config-substitution>
Re: svn commit: r662748 - /geronimo/server/trunk/plugins/javamail/javamail/pom.xml
Posted by Rick McGuire <ri...@gmail.com>.
Kevan Miller wrote:
>
> On Jun 3, 2008, at 12:41 PM, Rick McGuire wrote:
>
>> Joe Bohn wrote:
>>>
>>> Rick,
>>>
>>> Is there any reason to not include this fix in branches/2.1 as well?
>> Nope....other than I couldn't think of any reason why it needed to be
>> included either.
>
> IMO, it should be merged into 2.1 and 2.0 for that matter.
Oops, it looks like I was mistaken...it was just specified in a much
different manner in 2.0.
Rick
>
> --kevan
>
>
Re: svn commit: r662748 - /geronimo/server/trunk/plugins/javamail/javamail/pom.xml
Posted by Rick McGuire <ri...@gmail.com>.
Kevan Miller wrote:
>
> On Jun 3, 2008, at 12:41 PM, Rick McGuire wrote:
>
>> Joe Bohn wrote:
>>>
>>> Rick,
>>>
>>> Is there any reason to not include this fix in branches/2.1 as well?
>> Nope....other than I couldn't think of any reason why it needed to be
>> included either.
>
> IMO, it should be merged into 2.1 and 2.0 for that matter.
Well, I think I disagree with merging it into 2.0...the PortOffset value
didn't even exist back that far!
Rick
>
> --kevan
>
>
Re: svn commit: r662748 - /geronimo/server/trunk/plugins/javamail/javamail/pom.xml
Posted by Kevan Miller <ke...@gmail.com>.
On Jun 3, 2008, at 12:41 PM, Rick McGuire wrote:
> Joe Bohn wrote:
>>
>> Rick,
>>
>> Is there any reason to not include this fix in branches/2.1 as well?
> Nope....other than I couldn't think of any reason why it needed to
> be included either.
IMO, it should be merged into 2.1 and 2.0 for that matter.
--kevan
Re: svn commit: r662748 - /geronimo/server/trunk/plugins/javamail/javamail/pom.xml
Posted by Rick McGuire <ri...@gmail.com>.
Joe Bohn wrote:
>
> Rick,
>
> Is there any reason to not include this fix in branches/2.1 as well?
Nope....other than I couldn't think of any reason why it needed to be
included either.
Rick
>
> Joe
>
>
> rickmcguire@apache.org wrote:
>> Author: rickmcguire
>> Date: Tue Jun 3 04:37:37 2008
>> New Revision: 662748
>>
>> URL: http://svn.apache.org/viewvc?rev=662748&view=rev
>> Log:
>> GERONIMO-4096 Remove PortOffset from SMTPPort definition.
>>
>>
>> Modified:
>> geronimo/server/trunk/plugins/javamail/javamail/pom.xml
>>
>> Modified: geronimo/server/trunk/plugins/javamail/javamail/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/javamail/javamail/pom.xml?rev=662748&r1=662747&r2=662748&view=diff
>>
>> ==============================================================================
>>
>> --- geronimo/server/trunk/plugins/javamail/javamail/pom.xml (original)
>> +++ geronimo/server/trunk/plugins/javamail/javamail/pom.xml Tue Jun
>> 3 04:37:37 2008
>> @@ -79,7 +79,7 @@
>> <config-xml-content>
>> <gbean name="SMTPTransport">
>> <attribute
>> name="host">${SMTPHost}</attribute>
>> - <attribute
>> name="port">${SMTPPort + PortOffset}</attribute>
>> + <attribute
>> name="port">${SMTPPort}</attribute>
>> </gbean>
>> </config-xml-content>
>> <config-substitution
>> key="SMTPHost">localhost</config-substitution>
>>
>>
>>
>
>
Re: svn commit: r662748 - /geronimo/server/trunk/plugins/javamail/javamail/pom.xml
Posted by Joe Bohn <jo...@earthlink.net>.
Rick,
Is there any reason to not include this fix in branches/2.1 as well?
Joe
rickmcguire@apache.org wrote:
> Author: rickmcguire
> Date: Tue Jun 3 04:37:37 2008
> New Revision: 662748
>
> URL: http://svn.apache.org/viewvc?rev=662748&view=rev
> Log:
> GERONIMO-4096 Remove PortOffset from SMTPPort definition.
>
>
> Modified:
> geronimo/server/trunk/plugins/javamail/javamail/pom.xml
>
> Modified: geronimo/server/trunk/plugins/javamail/javamail/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/javamail/javamail/pom.xml?rev=662748&r1=662747&r2=662748&view=diff
> ==============================================================================
> --- geronimo/server/trunk/plugins/javamail/javamail/pom.xml (original)
> +++ geronimo/server/trunk/plugins/javamail/javamail/pom.xml Tue Jun 3 04:37:37 2008
> @@ -79,7 +79,7 @@
> <config-xml-content>
> <gbean name="SMTPTransport">
> <attribute name="host">${SMTPHost}</attribute>
> - <attribute name="port">${SMTPPort + PortOffset}</attribute>
> + <attribute name="port">${SMTPPort}</attribute>
> </gbean>
> </config-xml-content>
> <config-substitution key="SMTPHost">localhost</config-substitution>
>
>
>