You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by "Gerhard Petracek (JIRA)" <ji...@apache.org> on 2012/08/05 11:21:02 UTC
[jira] [Created] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Gerhard Petracek created DELTASPIKE-258:
-------------------------------------------
Summary: improve the compatibility with new versions of weld
Key: DELTASPIKE-258
URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
Project: DeltaSpike
Issue Type: Improvement
Components: CdiControl
Affects Versions: 0.2-incubating
Reporter: Gerhard Petracek
Assignee: Gerhard Petracek
Fix For: 0.3-incubating
org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg reopened DELTASPIKE-258:
--------------------------------------
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428865#comment-13428865 ]
Gerhard Petracek commented on DELTASPIKE-258:
---------------------------------------------
in general: -1 for just reverting a commit without looking at the details.
in this case it breaks the compatibility with all >new< versions of weld (because org.jboss.weld.context.beanstore.BeanStore changed).
+0 for removing the workaround in general (and to wait for concrete use-cases).
-> in this case we have to remove it in org.apache.deltaspike.cdise.weld.ContextController#stopApplicationScope.
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428833#comment-13428833 ]
Mark Struberg commented on DELTASPIKE-258:
------------------------------------------
-1 for the fix!
We agreed on the list that we will NOT do any dirty tricks for container bugs if they are not _really_ necessary.
In that case I frankly don't care if the shutdown fails in a single weld version. It's the _shutdown_! People will get nasty logs but that's it! The runtime of the application will _not_ be affected.
Other as that an application shall NOT stop the application context manually anyways. This might happen in unit tests - but in that case it is MUCH easier to just start the ApplicationContext again before the shutdown!
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg reopened DELTASPIKE-258:
--------------------------------------
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg resolved DELTASPIKE-258.
--------------------------------------
Resolution: Won't Fix
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428946#comment-13428946 ]
Mark Struberg commented on DELTASPIKE-258:
------------------------------------------
This is now fixed by removing all the workaround code and using the same logic which is also used in AS7 for async EJB.
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428885#comment-13428885 ]
Mark Struberg commented on DELTASPIKE-258:
------------------------------------------
Imo the whole underlying workaround is not needed. This are 200++ loc which are only there because of a bug in an old Weld version. And the workaround for this old bug now did cost another 400 lines of workaround. And so forth. This is an never ending spiral. We shall not use such internal hacks which are even not working for minor revision changes. This just adds up and once we will reach 80% codebase just for workarounds ;)
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg resolved DELTASPIKE-258.
--------------------------------------
Resolution: Fixed
I hope this is now fixed by stepping back and solving the original underlying problem. I really hope this works out because the other way is adding workarounds for workarounds,...
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg reassigned DELTASPIKE-258:
----------------------------------------
Assignee: Mark Struberg (was: Gerhard Petracek)
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek resolved DELTASPIKE-258.
-----------------------------------------
Resolution: Fixed
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (DELTASPIKE-258) improve the compatibility
with new versions of weld
Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428865#comment-13428865 ]
Gerhard Petracek edited comment on DELTASPIKE-258 at 8/5/12 4:04 PM:
---------------------------------------------------------------------
in general: -1 for just reverting a commit without looking at the details.
in this case it breaks the compatibility with all >new< versions of weld (because org.jboss.weld.context.beanstore.BeanStore changed).
+0 for removing the workaround in general (and to wait for concrete use-cases).
-> in this case we have to remove it in org.apache.deltaspike.cdise.weld.ContextController#stopApplicationScope.
@ "start the ApplicationContext again":
that isn't supported by weld
was (Author: gpetracek):
in general: -1 for just reverting a commit without looking at the details.
in this case it breaks the compatibility with all >new< versions of weld (because org.jboss.weld.context.beanstore.BeanStore changed).
+0 for removing the workaround in general (and to wait for concrete use-cases).
-> in this case we have to remove it in org.apache.deltaspike.cdise.weld.ContextController#stopApplicationScope.
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428927#comment-13428927 ]
Mark Struberg commented on DELTASPIKE-258:
------------------------------------------
Here we come to the core of the store:
Welds AbstractSharedContext#clear() is just clearing all stuff but not setting a fresh ConcurrentHashMapBeanStore. Thus we need another way to start a new Context.
According to stu we shall use the ManagedContext#invalidate() + ManagedContext#deactivate() for stopping and ManagedContext#activate() for starting again.
Here is a sample how it's done in AS7:
https://github.com/stuartwdouglas/jboss-as/blob/master/weld/src/main/java/org/jboss/as/weld/ejb/EjbRequestScopeActivationInterceptor.java#L92
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-258) improve the compatibility with
new versions of weld
Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428889#comment-13428889 ]
Gerhard Petracek commented on DELTASPIKE-258:
---------------------------------------------
i didn't say that we should keep it (i gave a +0 for removing it).
> improve the compatibility with new versions of weld
> ---------------------------------------------------
>
> Key: DELTASPIKE-258
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-258
> Project: DeltaSpike
> Issue Type: Improvement
> Components: CdiControl
> Affects Versions: 0.2-incubating
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.3-incubating
>
>
> org.jboss.weld.context.beanstore.BeanStore changed in the latest snapshots (and can be changed at any time). we should use a proxy for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira