You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/08/30 08:58:00 UTC
[jira] [Commented] (IMPALA-10888) getPartitionsByNames should
return partitions sorted by name
[ https://issues.apache.org/jira/browse/IMPALA-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406638#comment-17406638 ]
ASF subversion and git services commented on IMPALA-10888:
----------------------------------------------------------
Commit beb8019f5300bb163424e7fdfec50b8e4b796e26 in impala's branch refs/heads/master from Vihang Karajgaonkar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=beb8019 ]
IMPALA-10888: sort partitions by name before comparing in test
CatalogHmsFileMetadataTest and EnableCatalogdHmsCacheFlagTest
compare the partition filemetada which is returned over by
get_partitions_by_names HMS API. However, the catalogd's
implementation of API does not return the partitions in a
deterministic order. Hence the tests can fail intermittently.
The patch sorts the returned partitions by names before
making any comparisons to avoid the flakiness of the test.
Testing:
1. Modified existing test to do the sorting before
asserting the filemetadata comparison.
Change-Id: I75aa9d714e888ec7f7efd62e475ba1d3a3342256
Reviewed-on: http://gerrit.cloudera.org:8080/17812
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> getPartitionsByNames should return partitions sorted by name
> ------------------------------------------------------------
>
> Key: IMPALA-10888
> URL: https://issues.apache.org/jira/browse/IMPALA-10888
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Major
>
> The CatalogMetastoreServer's implementation of {{getPartitionByNames}} does not return partitions order by partition name whereas in case of HMS it orders them by partition name. While this is not a documented behavior and clients should not assume this it can cause test flakiness where we expect the order of the partitions to be consistent. We should change the implementation so that the returned partitions over this API are sorted by partition name.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org