You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Carlos Valiente (JIRA)" <ji...@apache.org> on 2008/11/05 22:17:44 UTC
[jira] Created: (THRIFT-193) Fix Perl namespaces
Fix Perl namespaces
-------------------
Key: THRIFT-193
URL: https://issues.apache.org/jira/browse/THRIFT-193
Project: Thrift
Issue Type: Bug
Components: Compiler (Perl)
Affects Versions: 0.1
Reporter: Carlos Valiente
Fix For: 0.1
Attachments: perl-namespaces.diff
I just had a look at the Perl stuff generated from tutorial.thrift:
tutorial/gen-perl/
shared/
Constants.pm
Types.pm
tutorial/
Constants.pm
Types.pm
Calculator.pm
SharedService.pm
Since 'Calculator' (resp. 'SharedService') is defined in 'tutorial.thrift'
(resp. 'shared.thrift'), whose namespace declaration is 'tutorial' (resp.
'shared'), I would have expected the following:
tutorial/gen-perl/
shared/
Constants.pm
Types.pm
SharedService.pm
tutorial/
Constants.pm
Types.pm
Calculator.pm
(Which is what you get for Python, by the way)
With the current layout, if I want to define a service called 'Calculator'
under my own namespace 'foo', I would get:
foo/
Constants.pm
Types.pm
Calculator.pm
,which would clash with Calculator.pm generated from tutorial.thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-193) Fix Perl namespaces
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani reassigned THRIFT-193:
-------------------------------------
Assignee: T Jake Luciani
> Fix Perl namespaces
> -------------------
>
> Key: THRIFT-193
> URL: https://issues.apache.org/jira/browse/THRIFT-193
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Fix For: 0.1
>
> Attachments: perl-namespaces.diff
>
>
> I just had a look at the Perl stuff generated from tutorial.thrift:
> ....tutorial/gen-perl/
> ........shared/
> ............Constants.pm
> ............Types.pm
> ........tutorial/
> ............Constants.pm
> ............Types.pm
> ........Calculator.pm
> ........SharedService.pm
> Since 'Calculator' (resp. 'SharedService') is defined in 'tutorial.thrift'
> (resp. 'shared.thrift'), whose namespace declaration is 'tutorial' (resp.
> 'shared'), I would have expected the following:
> ....tutorial/gen-perl/
> ........shared/
> ............Constants.pm
> ............Types.pm
> ............SharedService.pm
> ........tutorial/
> ............Constants.pm
> ............Types.pm
> ............Calculator.pm
> (Which is what you get for Python, by the way)
> With the current layout, if I want to define a service called 'Calculator'
> under my own namespace 'foo', I would get:
> ....foo/
> ........Constants.pm
> ........Types.pm
> ....Calculator.pm
> ,which would clash with Calculator.pm generated from tutorial.thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-193) Fix Perl namespaces
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani resolved THRIFT-193.
-----------------------------------
Resolution: Fixed
Excellent patch. Thanks!
Committed revision 728863
> Fix Perl namespaces
> -------------------
>
> Key: THRIFT-193
> URL: https://issues.apache.org/jira/browse/THRIFT-193
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Fix For: 0.1
>
> Attachments: perl-namespaces.diff
>
>
> I just had a look at the Perl stuff generated from tutorial.thrift:
> ....tutorial/gen-perl/
> ........shared/
> ............Constants.pm
> ............Types.pm
> ........tutorial/
> ............Constants.pm
> ............Types.pm
> ........Calculator.pm
> ........SharedService.pm
> Since 'Calculator' (resp. 'SharedService') is defined in 'tutorial.thrift'
> (resp. 'shared.thrift'), whose namespace declaration is 'tutorial' (resp.
> 'shared'), I would have expected the following:
> ....tutorial/gen-perl/
> ........shared/
> ............Constants.pm
> ............Types.pm
> ............SharedService.pm
> ........tutorial/
> ............Constants.pm
> ............Types.pm
> ............Calculator.pm
> (Which is what you get for Python, by the way)
> With the current layout, if I want to define a service called 'Calculator'
> under my own namespace 'foo', I would get:
> ....foo/
> ........Constants.pm
> ........Types.pm
> ....Calculator.pm
> ,which would clash with Calculator.pm generated from tutorial.thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-193) Fix Perl namespaces
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani closed THRIFT-193.
---------------------------------
> Fix Perl namespaces
> -------------------
>
> Key: THRIFT-193
> URL: https://issues.apache.org/jira/browse/THRIFT-193
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Assignee: T Jake Luciani
> Fix For: 0.1
>
> Attachments: perl-namespaces.diff
>
>
> I just had a look at the Perl stuff generated from tutorial.thrift:
> ....tutorial/gen-perl/
> ........shared/
> ............Constants.pm
> ............Types.pm
> ........tutorial/
> ............Constants.pm
> ............Types.pm
> ........Calculator.pm
> ........SharedService.pm
> Since 'Calculator' (resp. 'SharedService') is defined in 'tutorial.thrift'
> (resp. 'shared.thrift'), whose namespace declaration is 'tutorial' (resp.
> 'shared'), I would have expected the following:
> ....tutorial/gen-perl/
> ........shared/
> ............Constants.pm
> ............Types.pm
> ............SharedService.pm
> ........tutorial/
> ............Constants.pm
> ............Types.pm
> ............Calculator.pm
> (Which is what you get for Python, by the way)
> With the current layout, if I want to define a service called 'Calculator'
> under my own namespace 'foo', I would get:
> ....foo/
> ........Constants.pm
> ........Types.pm
> ....Calculator.pm
> ,which would clash with Calculator.pm generated from tutorial.thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-193) Fix Perl namespaces
Posted by "Carlos Valiente (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Valiente updated THRIFT-193:
-----------------------------------
Attachment: perl-namespaces.diff
Diff against Subversion trunk
> Fix Perl namespaces
> -------------------
>
> Key: THRIFT-193
> URL: https://issues.apache.org/jira/browse/THRIFT-193
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Fix For: 0.1
>
> Attachments: perl-namespaces.diff
>
>
> I just had a look at the Perl stuff generated from tutorial.thrift:
> tutorial/gen-perl/
> shared/
> Constants.pm
> Types.pm
> tutorial/
> Constants.pm
> Types.pm
> Calculator.pm
> SharedService.pm
> Since 'Calculator' (resp. 'SharedService') is defined in 'tutorial.thrift'
> (resp. 'shared.thrift'), whose namespace declaration is 'tutorial' (resp.
> 'shared'), I would have expected the following:
> tutorial/gen-perl/
> shared/
> Constants.pm
> Types.pm
> SharedService.pm
> tutorial/
> Constants.pm
> Types.pm
> Calculator.pm
> (Which is what you get for Python, by the way)
> With the current layout, if I want to define a service called 'Calculator'
> under my own namespace 'foo', I would get:
> foo/
> Constants.pm
> Types.pm
> Calculator.pm
> ,which would clash with Calculator.pm generated from tutorial.thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-193) Fix Perl namespaces
Posted by "Carlos Valiente (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Valiente updated THRIFT-193:
-----------------------------------
Description:
I just had a look at the Perl stuff generated from tutorial.thrift:
....tutorial/gen-perl/
........shared/
............Constants.pm
............Types.pm
........tutorial/
............Constants.pm
............Types.pm
........Calculator.pm
........SharedService.pm
Since 'Calculator' (resp. 'SharedService') is defined in 'tutorial.thrift'
(resp. 'shared.thrift'), whose namespace declaration is 'tutorial' (resp.
'shared'), I would have expected the following:
....tutorial/gen-perl/
........shared/
............Constants.pm
............Types.pm
............SharedService.pm
........tutorial/
............Constants.pm
............Types.pm
............Calculator.pm
(Which is what you get for Python, by the way)
With the current layout, if I want to define a service called 'Calculator'
under my own namespace 'foo', I would get:
....foo/
........Constants.pm
........Types.pm
....Calculator.pm
,which would clash with Calculator.pm generated from tutorial.thrift.
was:
I just had a look at the Perl stuff generated from tutorial.thrift:
tutorial/gen-perl/
shared/
Constants.pm
Types.pm
tutorial/
Constants.pm
Types.pm
Calculator.pm
SharedService.pm
Since 'Calculator' (resp. 'SharedService') is defined in 'tutorial.thrift'
(resp. 'shared.thrift'), whose namespace declaration is 'tutorial' (resp.
'shared'), I would have expected the following:
tutorial/gen-perl/
shared/
Constants.pm
Types.pm
SharedService.pm
tutorial/
Constants.pm
Types.pm
Calculator.pm
(Which is what you get for Python, by the way)
With the current layout, if I want to define a service called 'Calculator'
under my own namespace 'foo', I would get:
foo/
Constants.pm
Types.pm
Calculator.pm
,which would clash with Calculator.pm generated from tutorial.thrift.
> Fix Perl namespaces
> -------------------
>
> Key: THRIFT-193
> URL: https://issues.apache.org/jira/browse/THRIFT-193
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Perl)
> Affects Versions: 0.1
> Reporter: Carlos Valiente
> Fix For: 0.1
>
> Attachments: perl-namespaces.diff
>
>
> I just had a look at the Perl stuff generated from tutorial.thrift:
> ....tutorial/gen-perl/
> ........shared/
> ............Constants.pm
> ............Types.pm
> ........tutorial/
> ............Constants.pm
> ............Types.pm
> ........Calculator.pm
> ........SharedService.pm
> Since 'Calculator' (resp. 'SharedService') is defined in 'tutorial.thrift'
> (resp. 'shared.thrift'), whose namespace declaration is 'tutorial' (resp.
> 'shared'), I would have expected the following:
> ....tutorial/gen-perl/
> ........shared/
> ............Constants.pm
> ............Types.pm
> ............SharedService.pm
> ........tutorial/
> ............Constants.pm
> ............Types.pm
> ............Calculator.pm
> (Which is what you get for Python, by the way)
> With the current layout, if I want to define a service called 'Calculator'
> under my own namespace 'foo', I would get:
> ....foo/
> ........Constants.pm
> ........Types.pm
> ....Calculator.pm
> ,which would clash with Calculator.pm generated from tutorial.thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.