You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/12/21 03:19:14 UTC

[GitHub] [pulsar-client-go] wolfstudy commented on issue #138: Enable golangci lint for project

wolfstudy commented on issue #138: Enable golangci lint for project
URL: https://github.com/apache/pulsar-client-go/pull/138#issuecomment-568147595
 
 
   - `if` block ends with a `return` statement, so drop this `else` and outdent its block (golint)
   
   ```
   if err != nil {
   		return nil, err
   	} else {
   		return internal.NewBufferWrapper(uncompressed), nil
   	}
   ```
   
   - comment on exported var `FlagProfile` should be of the form `FlagProfile ...` (golint)
   
   ```
   // global flags
   var FlagProfile bool
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services