You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/14 17:31:01 UTC

[jira] [Commented] (FLINK-8630) To support JSON schema to TypeInformation conversion

    [ https://issues.apache.org/jira/browse/FLINK-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364483#comment-16364483 ] 

ASF GitHub Bot commented on FLINK-8630:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/5491

    [FLINK-8630] [table] To support JSON schema to TypeInformation conversion

    ## What is the purpose of the change
    
    This PR implements (almost) full support of the JSON type. It includes:
    
    - Schema to TypeInformation conversion
    - Support for `number`, `integer`, `string`, `object`, `array` types
    - Initial support for date, time, and timestamp format and mapping to Flink types
    - Support for base64 encoded byte arrays
    - Nested support
    
    ## Brief change log
    
    - New module `flink-json` in `flink-formats`
    - New JsonSchemaConverter
    - Improved JsonRowSerialization/DeserializationSchema
    
    ## Verifying this change
    
    - Improved existing tests
    - New unit tests
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): yes
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? will document together with first JSON connector


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-8630

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5491
    
----
commit 7e18fbfb560aea10935a549b9dc4075f7018eb75
Author: twalthr <tw...@...>
Date:   2018-02-12T17:18:44Z

    [FLINK-8630] [table] To support JSON schema to TypeInformation conversion

----


> To support JSON schema to TypeInformation conversion 
> -----------------------------------------------------
>
>                 Key: FLINK-8630
>                 URL: https://issues.apache.org/jira/browse/FLINK-8630
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Streaming Connectors
>            Reporter: Xingcan Cui
>            Assignee: Timo Walther
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> To support (FLINK-8558), we need to generate a \{{TypeInformation}} from a standard [JSON schema|http://json-schema.org/] (and maybe vice verse). There are some problems to be discussed, e.g., how to handle JSON {{Number}} type. One option would be we always return a specific type, which can be configured to be double or BigDecimal, for it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)