You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by HansBrende <gi...@git.apache.org> on 2018/04/02 08:39:01 UTC

[GitHub] any23 pull request #69: ANY23-336 Hacky patch to tide us over until jsonldja...

GitHub user HansBrende opened a pull request:

    https://github.com/apache/any23/pull/69

    ANY23-336 Hacky patch to tide us over until jsonldjava 0.11.2 release

    This is a hacky patch for Any23 that does exactly the same thing my [JSONLD-JAVA pull request](https://github.com/jsonld-java/jsonld-java/pull/228) does.
    
    With this patch in place, the amortized extraction time for the site https://www.guthriegreen.com dropped from 30 seconds to 0.3 seconds, a difference of **two orders of magnitude**!!! 😱😮😵
    
    This patch should be removed as soon as we can upgrade to JSONLD-JAVA version 0.11.2.
    
    mvn clean test -> all tests pass.
    
    @lewismc @ansell Any comments before I merge this? 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HansBrende/any23 ANY23-336

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/any23/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
    
----
commit 80a5c5230ba55fa1f36166baccf4a5ac5d157a73
Author: Hans <fi...@...>
Date:   2018-04-02T08:05:34Z

    ANY23-336 Hacky patch to tide us over until jsonldjava 0.11.2 release

----


---

[GitHub] any23 pull request #69: ANY23-336 Hacky patch to tide us over until jsonldja...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/any23/pull/69


---

[GitHub] any23 issue #69: ANY23-336 Hacky patch to tide us over until jsonldjava 0.11...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/69
  
    I pulled this locally and tested. In terms of the extraction performance, I can confirm a significant improvement. I would be +1 to merging into master.


---