You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/14 12:08:23 UTC

[GitHub] [incubator-doris] morrySnow opened a new pull request, #10134: [style](fe)the last step of fe CheckStyle

morrySnow opened a new pull request, #10134:
URL: https://github.com/apache/incubator-doris/pull/10134

   1. fix all CheckStyle warning
   2. change all CheckStyle rules to error
   3. remove some java doc rules
       a. RequireEmptyLineBeforeBlockTagGroup
       b. JavadocStyle
       c. JavadocParagraph
   4. suppress some rules for old codes
       a. all java doc rules only affect on Nereids
       b. DeclarationOrder only affect on Nereids
       c. OverloadMethodsDeclarationOrder only affect on Nereids
       d. VariableDeclarationUsageDistance only affect on Nereids
       e. suppress OneTopLevelClass on org/apache/doris/load/loadv2/dpp/ColumnParser.java
       f. suppress OneTopLevelClass on org/apache/doris/load/loadv2/dpp/SparkRDDAggregator.java
       g. suppress LineLength on org/apache/doris/catalog/FunctionSet.java
       h. suppress LineLength on org/apache/doris/common/ErrorCode.java
   
   # Proposed changes
   
   Issue Number: close #9406
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: No
   2. Has unit tests been added: No Need
   3. Has document been added or modified: No
   4. Does it need to update dependencies: No
   5. Are there any changes that cannot be rolled back: No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10134: [style](fe)the last step of fe CheckStyle

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10134:
URL: https://github.com/apache/doris/pull/10134#issuecomment-1158799038

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morningman merged pull request #10134: [style](fe)the last step of fe CheckStyle

Posted by GitBox <gi...@apache.org>.
morningman merged PR #10134:
URL: https://github.com/apache/doris/pull/10134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morningman commented on pull request #10134: [style](fe)the last step of fe CheckStyle

Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10134:
URL: https://github.com/apache/doris/pull/10134#issuecomment-1158798958

   I will quick merge it to avoid conflict


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10134: [style](fe)the last step of fe CheckStyle

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10134:
URL: https://github.com/apache/doris/pull/10134#issuecomment-1158799017

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org