You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by MartinStyk <gi...@git.apache.org> on 2016/09/07 07:26:55 UTC
[GitHub] activemq-artemis pull request #755: ARTEMIS-713 Possible integer overflow in...
GitHub user MartinStyk opened a pull request:
https://github.com/apache/activemq-artemis/pull/755
ARTEMIS-713 Possible integer overflow in SubscriptionsResource.recrea\u2026
\u2026teTopicConsumer
Artemis Jira: https://issues.apache.org/jira/browse/ARTEMIS-713
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MartinStyk/activemq-artemis ARTEMIS-713
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #755
----
commit 78409ae5e92804d3638eac918d567e96988be03d
Author: Martin Styk <ms...@redhat.com>
Date: 2016-09-07T07:25:57Z
ARTEMIS-713 Possible integer overflow in SubscriptionsResource.recreateTopicConsumer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #755: ARTEMIS-713 Possible integer overflow in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/755
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #755: ARTEMIS-713 Possible integer overflow in...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/755#discussion_r77818414
--- Diff: artemis-rest/src/main/java/org/apache/activemq/artemis/rest/topic/SubscriptionsResource.java ---
@@ -376,7 +376,7 @@ private QueueConsumer recreateTopicConsumer(String subscriptionId, boolean autoA
if (subscriptionExists(subscriptionId)) {
QueueConsumer tmp = null;
try {
- tmp = createConsumer(true, autoAck, subscriptionId, null, consumerTimeoutSeconds * 1000, false);
--- End diff --
it doesn't hurt though \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #755: ARTEMIS-713 Possible integer overflow in...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/755#discussion_r77818379
--- Diff: artemis-rest/src/main/java/org/apache/activemq/artemis/rest/topic/SubscriptionsResource.java ---
@@ -376,7 +376,7 @@ private QueueConsumer recreateTopicConsumer(String subscriptionId, boolean autoA
if (subscriptionExists(subscriptionId)) {
QueueConsumer tmp = null;
try {
- tmp = createConsumer(true, autoAck, subscriptionId, null, consumerTimeoutSeconds * 1000, false);
--- End diff --
I thought the compiler would solve this by converting it to long. The outcome is a long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---