[GitHub] [incubator-dolphinscheduler] chengshiwen edited a comment on pull request #4769: [Improvement][SQL] Remove unused table: t_ds_master_server and t_ds_worker_server

[GitBox <gi...@apache.org>]

chengshiwen edited a comment on pull request #4769:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4769#issuecomment-797390198


   > @chengshiwen Hi, I think it not need to update the old table struct, Because the contents of create ddl under 1.0.0 or 1.2.0 need be consistant with the table struct of version 1.0.0 or 1.2.0.
   
   Now all sql records are incomplete about `master_server` and `worker_server`. In summary,
   
   The following is all the operation records of mysql:
   
   - `sql/create/release-1.0.0_schema/mysql/dolphinscheduler_ddl.sql`:
     - create `t_escheduler_master_server` and `t_escheduler_worker_server`
   - `sql/upgrade/1.2.0_schema/mysql/dolphinscheduler_ddl.sql`:
     - rename `t_escheduler_master_server` to `t_ds_master_server`
     - rename `t_escheduler_worker_server` to `t_ds_worker_server`
   
   **But there is no record of `master_server` or `worker_server` in `sql/dolphinscheduler_mysql.sql`**
   
   The following is all the operation records of postgresql:
   
   - `sql/create/release-1.2.0_schema/postgresql/dolphinscheduler_ddl.sql`
     - create `t_ds_master_server` and `t_ds_worker_server`
   -  `sql/dolphinscheduler_postgre.sql`
     - only create `t_ds_worker_server` 
   
   **But there is no record of `t_ds_master_server` in `sql/dolphinscheduler_postgre.sql`**
   
   Since we did not actually use these tables, and there will be no impact on the upgrade, but all sql records are still incomplete. Therefore, **I suggest to either remove all unused tables or complete the missing sql records**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org