[jira] [Commented] (FLINK-6247) Build a jar-with-dependencies for flink-table and put it into ./opt

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954418#comment-15954418 ] 

ASF GitHub Bot commented on FLINK-6247:
---------------------------------------

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/3666

    [FLINK-6247][table] Build a jar-with-dependencies for flink-table and…

    … put it into ./opt
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-6247] Build a jar-with-dependencies for flink-table and put it into ./opt")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-6247-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3666
    
----
commit 5c2ddf580d23e7745499c0d5f639b18d766e6d24
Author: sunjincheng121 <su...@gmail.com>
Date:   2017-03-31T08:31:18Z

    [FLINK-6247][table] Build a jar-with-dependencies for flink-table and put it into ./opt

----


> Build a jar-with-dependencies for flink-table and put it into ./opt
> -------------------------------------------------------------------
>
>                 Key: FLINK-6247
>                 URL: https://issues.apache.org/jira/browse/FLINK-6247
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System, Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: Fabian Hueske
>            Assignee: sunjincheng
>
> Due to a problem with Calcite and the unloading of classes, user-code classloaders that include Calcite cannot be garbage collected. This is a problem for long-running clusters that execute multiple Table API / SQL programs with fat JARs that include the flink-table dependency. Each executed program comes with an own user-code classloader that cannot be cleaned up later.
> As a workaround, we recommend to copy the flink-table dependency into the ./lib folder. However, we do not have a jar file with all required transitive dependencies (Calcite, Janino, etc). Hence, users would need to build this jar file themselves or copy all jars into ./lib.
> This issue is about creating a jar-with-dependencies and adding it to the ./opt folder. Users can then copy the jar file from ./opt to ./lib to include the table API in the classpath of Flink.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)