You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/10/13 19:29:34 UTC
[GitHub] [fineract] BLasan commented on pull request #1886: Fineract-429 Node aware job scheduler
BLasan commented on pull request #1886:
URL: https://github.com/apache/fineract/pull/1886#issuecomment-942648319
```
public·interface·GLAccountRepository·extends·JpaRepository<GLAccount,·Long>,·JpaSpecificationExecutor<GLAccount>·{
+
····//·no·added·behaviour
-····//adding·behaviour·to·fetch·id·by·glcode·for·opening·balance·bulk·import
+····//·adding·behaviour·to·fetch·id·by·glcode·for·opening·balance·bulk·import
····Optional<GLAccount>·findOneByGlCode(String·glCode);
}
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountRepositoryWrapper.java
@@ -40,7 +40,8 @@
····public·GLAccount·findOneWithNotFoundDetection(final·Long·id)·{
········return·this.repository.findById(id).orElseThrow(()·->·new·GLAccountNotFoundException(id));
····}
-····//finding·account·id·by·glcode·for·opening·balance·bulk·import
+
+····//·finding·account·id·by·glcode·for·opening·balance·bulk·import
····public·GLAccount·findOneByGlCodeWithNotFoundDetection(final·String·glCode)·{
········return·this.repository.findOneByGlCode(glCode).orElseThrow(()·->·new·GLAccountNotFoundException(glCode));
····}
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/data/JournalEntryData.java
@@ -90,7 +90,8 @@
····private·String·routingCode;
····private·String·receiptNumber;
····private·String·bankNumber;
-····//for·opening·bal·bulk·import
+
+····//·for·opening·bal·bulk·import
····public·JournalEntryData(Long·officeId,·LocalDate·transactionDate,·String·currencyCode,·List<CreditDebit>·credits,
············List<CreditDebit>·debits,·String·locale,·String·dateFormat)·{
········this.officeId·=·officeId;
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/constants/ChartOfAcountsConstants.java
@@ -34,7 +34,7 @@
····public·static·final·int·TAG_COL·=·7;//·H
····public·static·final·int·TAG_ID_COL·=·8;//·I
····public·static·final·int·DESCRIPTION_COL·=·9;//·J
-····//adding·for·opening·balance·bulk·import
+····//·adding·for·opening·balance·bulk·import
····public·static·final·int·OFFICE_COL·=·10;·//·K
····public·static·final·int·OFFICE_COL_ID·=·11;·//·L
····public·static·final·int·CURRENCY_CODE·=·12;·//·M
@@ -47,7 +47,7 @@
····public·static·final·int·LOOKUP_TAG_COL·=·21;·//·V
····public·static·final·int·LOOKUP_TAG_ID_COL·=·22;·//·W
-····//adding·for·opening·balance·bulk·import
+····//·adding·for·opening·balance·bulk·import
····public·static·final·int·LOOKUP_OFFICE_COL·=·23;·//·X
... (2 more lines that didn't fit)
Violations also present in:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/chartofaccounts/ChartOfAccountsWorkbook.java
Run './gradlew :fineract-provider:spotlessApply' to fix these violations.
```
Haven't done such kind of change. Why this fails by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org