[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8522: [WIP][dashboard scoped filter] part 3: merge filter scope settings into dashboard redux state

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on issue #8522: [WIP][dashboard scoped filter] part 3: merge filter scope settings into dashboard redux state
URL: https://github.com/apache/incubator-superset/pull/8522#issuecomment-553243913
 
 
   A few updates in the last commits, based on users and designer's feedack:
   
   1. Replace `Select/deselect all filters` to `All filters`. Replace `Select/deselect all charts` to `All charts`
   2. Click on `Save` button should update filter scopes setting to redux state, and **close** modal.
   3. Fix the bug that filter scopes settings are not saved to backend.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org