[GitHub] [spark] mengxr commented on a change in pull request #24374: [SPARK-27366][CORE] Support GPU Resources in Spark job scheduling

[GitBox <gi...@apache.org>]

mengxr commented on a change in pull request #24374: [SPARK-27366][CORE] Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r287224204
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkConf.scala
 ##########
 @@ -507,6 +507,15 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
     }
   }
 
+  /**
+   * Get task resource requirements.
+   */
+  private[spark] def getTaskResourceRequirements(): Map[String, Int] = {
 
 Review comment:
   Need unit test or leave a TODO since this might go away with the conf refactoring.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org