You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by drigodwin <gi...@git.apache.org> on 2016/07/06 16:53:01 UTC

[GitHub] brooklyn-docs pull request #87: Fixed broken links

GitHub user drigodwin opened a pull request:

    https://github.com/apache/brooklyn-docs/pull/87

    Fixed broken links

    Fixed broken links throughout the docs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/drigodwin/brooklyn-docs link-corrections

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-docs/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #87
    
----
commit d80395fcfdd58d48e197cbf2c5be259a39c18c09
Author: Duncan Godwin <du...@cloudsoftcorp.com>
Date:   2016-07-06T16:51:36Z

    Fixed links

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request #87: Fixed broken links

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-docs/pull/87


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request #87: Fixed broken links

Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-docs/pull/87#discussion_r69880520
  
    --- Diff: _plugins/brooklyn_metadata.rb ---
    @@ -44,7 +44,7 @@ def generate(site)
             }
           end
           
    -      url_set["git"] = "https://github.com/apache/brooklyn/tree/#{ git_branch }"
    +      url_set["git"] = "https://github.com/apache/brooklyn-server/tree/#{ git_branch }"
    --- End diff --
    
    Yes, it needs re-working. For this though, I manually checked all the places this is being used and they're all currently in brooklyn-server.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request #87: Fixed broken links

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-docs/pull/87#discussion_r69878970
  
    --- Diff: _plugins/brooklyn_metadata.rb ---
    @@ -44,7 +44,7 @@ def generate(site)
             }
           end
           
    -      url_set["git"] = "https://github.com/apache/brooklyn/tree/#{ git_branch }"
    +      url_set["git"] = "https://github.com/apache/brooklyn-server/tree/#{ git_branch }"
    --- End diff --
    
    this could be wrong for some classes -- we need a more sophisticated strategy to determine if it's `server` or `library` etc (but this is probably good enough for now)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---