You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/29 10:05:53 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5371: arch/Toolchain.defs: Don't expand EXTRA_LIBS immediately
xiaoxiang781216 opened a new pull request #5371:
URL: https://github.com/apache/incubator-nuttx/pull/5371
since board's Make.defs may overwrite ARCHCPUFLAGS
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #5371: arch/Toolchain.defs: Don't expand EXTRA_LIBS immediately
Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on pull request #5371:
URL: https://github.com/apache/incubator-nuttx/pull/5371#issuecomment-1024886178
@xiaoxiang781216
The link error for sama5d4-ek:knsh has been resolved.
However, I noticed that some libraries such as libgcc.a and libm.a are still missing for import.
```
$ cd apps
$ find . -name '*.a'
./libapps.a
./import/libs/libmm.a
./import/libs/libapps.a
./import/libs/libproxies.a
./import/libs/libarch.a
./import/libs/libc.a
./import/libs/libxx.a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5371: arch/Toolchain.defs: Don't expand EXTRA_LIBS immediately
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #5371:
URL: https://github.com/apache/incubator-nuttx/pull/5371#issuecomment-1025050567
@xiaoxiang781216
>But It doesn't make sense to export libgcc.a and libm.a, since the user can get these built-in library from toolchain again.
I understand.
I will create a new PR that modifies apps/import/Make.defs later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5371: arch/Toolchain.defs: Don't expand EXTRA_LIBS immediately
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #5371:
URL: https://github.com/apache/incubator-nuttx/pull/5371#issuecomment-1024886178
@xiaoxiang781216
The link error for sama5d4-ek:ksh has been resolved.
However, I noticed that some libraries such as libgcc.a and libm.a are missing for import.
```
$ cd apps
$ find . -name '*.a'
./libapps.a
./import/libs/libmm.a
./import/libs/libapps.a
./import/libs/libproxies.a
./import/libs/libarch.a
./import/libs/libc.a
./import/libs/libxx.a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5371: arch/Toolchain.defs: Don't expand EXTRA_LIBS immediately
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #5371:
URL: https://github.com/apache/incubator-nuttx/pull/5371#issuecomment-1024912449
@xiaoxiang781216
>However, I noticed that some libraries such as libgcc.a and libm.a are still missing for import.
I think it still affects nuttx/tools/mkexport.sh which generates nuttx-export-x.x.x.zip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5371: arch/Toolchain.defs: Don't expand EXTRA_LIBS immediately
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #5371:
URL: https://github.com/apache/incubator-nuttx/pull/5371#issuecomment-1024952748
> @xiaoxiang781216 The link error for sama5d4-ek:knsh has been resolved. However, I noticed that some libraries such as libgcc.a and libm.a are still missing for import.
>
> ```
> $ cd apps
> $ find . -name '*.a'
> ./libapps.a
> ./import/libs/libmm.a
> ./import/libs/libapps.a
> ./import/libs/libproxies.a
> ./import/libs/libarch.a
> ./import/libs/libc.a
> ./import/libs/libxx.a
> ```
But It doesn't make sense to export libgcc.a and libm.a, since the user can get these built-in library from toolchain again. If we package the built-in library, should we package the full toolchain together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5371: arch/Toolchain.defs: Don't expand EXTRA_LIBS immediately
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5371:
URL: https://github.com/apache/incubator-nuttx/pull/5371#issuecomment-1024952748
> @xiaoxiang781216 The link error for sama5d4-ek:knsh has been resolved. However, I noticed that some libraries such as libgcc.a and libm.a are still missing for import.
>
> ```
> $ cd apps
> $ find . -name '*.a'
> ./libapps.a
> ./import/libs/libmm.a
> ./import/libs/libapps.a
> ./import/libs/libproxies.a
> ./import/libs/libarch.a
> ./import/libs/libc.a
> ./import/libs/libxx.a
> ```
But It doesn't make sense to export libgcc.a and libm.a, since the user can get these built-in library from toolchain again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #5371: arch/Toolchain.defs: Don't expand EXTRA_LIBS immediately
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #5371:
URL: https://github.com/apache/incubator-nuttx/pull/5371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org