You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/18 05:41:26 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #431: Add bypassvlanoverlapcheck parameter when create private gateway
davidjumani opened a new pull request #431:
URL: https://github.com/apache/cloudstack-primate/pull/431
Fixes #403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #431: Add bypassvlanoverlapcheck parameter when create private gateway
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #431:
URL: https://github.com/apache/cloudstack-primate/pull/431#issuecomment-645852147
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #431: Add bypassvlanoverlapcheck parameter when create private gateway
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #431:
URL: https://github.com/apache/cloudstack-primate/pull/431#discussion_r442001952
##########
File path: src/config/section/network.js
##########
@@ -285,7 +285,8 @@ export default {
icon: 'plus',
label: 'label.add.private.gateway',
listView: true,
- args: ['physicalnetworkid', 'vlan', 'ipaddress', 'gateway', 'netmask', 'sourcenatsupported', 'aclid'],
+ // TODO : Add version check
+ args: ['physicalnetworkid', 'vlan', 'bypassvlanoverlapcheck', 'ipaddress', 'gateway', 'netmask', 'sourcenatsupported', 'aclid'],
Review comment:
@davidjumani no need, instead use the syntax to return args from a method (see example where args can be a `() => { return ...`). Basically you can use the example I showed you yesterday to check if param is available in the API to include in the args keys or no (i.e. check API discovery api.params if it exists, if yes return otherwise don't).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #431: Add bypassvlanoverlapcheck parameter when create private gateway
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #431:
URL: https://github.com/apache/cloudstack-primate/pull/431#issuecomment-645851760
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #431: Add bypassvlanoverlapcheck parameter when create private gateway
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #431:
URL: https://github.com/apache/cloudstack-primate/pull/431#issuecomment-645856205
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/431 (JID-2045)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #431: Add bypassvlanoverlapcheck parameter when create private gateway
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #431:
URL: https://github.com/apache/cloudstack-primate/pull/431#issuecomment-645907346
@rhtyd Good to go! Also fixed missing vpcid when trying to create a private gateway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #431: Add bypassvlanoverlapcheck parameter when create private gateway
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #431:
URL: https://github.com/apache/cloudstack-primate/pull/431#discussion_r442002394
##########
File path: src/views/network/VpcTab.vue
##########
@@ -130,6 +130,12 @@
v-decorator="['vlan', {rules: [{ required: true, message: `${this.$t('label.required')}` }]}]"
></a-input>
</a-form-item>
+ // TODO : Add version check
+ <a-form-item :label="$t('label.bypassvlanoverlapcheck')">
Review comment:
Add check to see if API param is available, @davidjumani see https://github.com/apache/cloudstack-primate/commit/e606fe93560bc7b7d45baaa7b9193a4d60ab8b86
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #431: Add bypassvlanoverlapcheck parameter when create private gateway
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #431:
URL: https://github.com/apache/cloudstack-primate/pull/431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org