[jira] [Commented] (KYLIN-2702) Ineffective null check in DataModelDesc#initComputedColumns()

["Shaofeng SHI (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097345#comment-16097345 ] 

Shaofeng SHI commented on KYLIN-2702:
-------------------------------------

This has been fixed together with other changes; When I look into, there is no such issue there, so I would mark it as fixed now.

> Ineffective null check in DataModelDesc#initComputedColumns()
> -------------------------------------------------------------
>
>                 Key: KYLIN-2702
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2702
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>     private void initComputedColumns(Map<String, CCInfo> ccInfoMap) {
>         if (ccInfoMap == null) {
>             logger.error("cc info map is null");
>         }
> ...
>             CCInfo other = ccInfoMap.get(thisCCName);
> {code}
> Subsequent access to ccInfoMap may produce NPE.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)