You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/08/31 18:04:24 UTC
Review Request 72823: Made UpdateFramework tests not rely on redundant
FRAMEWORK_UPDATED.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72823/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10166
https://issues.apache.org/jira/browse/MESOS-10166
Repository: mesos
Description
-------
This patch adjusts UpdateFramework tests so that they do not rely on
an API subscriber receiving the FRAMEWORK_UPDATED event when the
UPDATE_FRAMEWORK call does not change the `FrameworkInfo`.
This is a prerequisite for removing redundant updates and broadcasts
when UPDATE_FRAMEWORK leaves `FrameworkInfo` the same.
Diffs
-----
src/tests/master/update_framework_tests.cpp 6346a4eaf2b6c70d1a7d5f32706e781436d36521
Diff: https://reviews.apache.org/r/72823/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72823: Made UpdateFramework tests not rely on
redundant FRAMEWORK_UPDATED.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72823/#review221759
-----------------------------------------------------------
Ship it!
Could you clarify a bit in the description around how the update framework call can be used to change suppressed roles which is not part of the framework info?
- Benjamin Mahler
On Aug. 31, 2020, 6:04 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72823/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2020, 6:04 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10166
> https://issues.apache.org/jira/browse/MESOS-10166
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adjusts UpdateFramework tests so that they do not rely on
> an API subscriber receiving the FRAMEWORK_UPDATED event when the
> UPDATE_FRAMEWORK call does not change the `FrameworkInfo`.
>
> This is a prerequisite for removing redundant updates and broadcasts
> when UPDATE_FRAMEWORK leaves `FrameworkInfo` the same.
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 6346a4eaf2b6c70d1a7d5f32706e781436d36521
>
>
> Diff: https://reviews.apache.org/r/72823/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>