[cloudstack-primate] branch master updated: configuration: notify admin to restart MS for non-dynamic settings (#290)

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
     new 322a445  configuration: notify admin to restart MS for non-dynamic settings (#290)
322a445 is described below

commit 322a445a924def3adc408205865211676b214e12
Author: Abhishek Kumar <ab...@gmail.com>
AuthorDate: Fri Apr 17 13:03:47 2020 +0530

    configuration: notify admin to restart MS for non-dynamic settings (#290)
    
    Fixes #83
    
    Signed-off-by: Abhishek Kumar <ab...@gmail.com>
---
 src/components/view/ListView.vue | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/components/view/ListView.vue b/src/components/view/ListView.vue
index b43b766..2f01845 100644
--- a/src/components/view/ListView.vue
+++ b/src/components/view/ListView.vue
@@ -266,14 +266,19 @@ export default {
       api('updateConfiguration', {
         name: record.name,
         value: this.editableValue
-      }).then(() => {
+      }).then(json => {
         this.editableValueKey = null
 
         this.$message.success('Setting Updated: ' + record.name)
-        this.$notification.warning({
-          message: 'Status',
-          description: 'Please restart your management server(s) for your new settings to take effect.'
-        })
+        if (json.updateconfigurationresponse &&
+          json.updateconfigurationresponse.configuration &&
+          !json.updateconfigurationresponse.configuration.isdynamic &&
+          ['Admin'].includes(this.$store.getters.userInfo.roletype)) {
+          this.$notification.warning({
+            message: 'Status',
+            description: 'Please restart your management server(s) for your new settings to take effect.'
+          })
+        }
       }).catch(error => {
         console.error(error)
         this.$message.error('There was an error saving this setting.')