You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2016/04/29 11:22:07 UTC

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/1381

    STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log to warn from error

    This error is transient most of the time and will occur during normal operation. Downgrading it to warning makes the error log much less noisy.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-1746

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1381
    
----
commit 7e5b9c50c54dba43e2cac1b5f0ad3c7eb001d060
Author: Stig Rohde Døssing <sd...@it-minds.dk>
Date:   2016-04-29T09:20:32Z

    STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log to warn from error

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1381#discussion_r61556517
  
    --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaUtils.java ---
    @@ -213,7 +213,11 @@ public static ByteBufferMessageSet fetchMessages(KafkaConfig config, SimpleConsu
                     throw new TopicOffsetOutOfRangeException(msg);
                 } else {
                     String message = "Error fetching data from [" + partition + "] for topic [" + topic + "]: [" + error + "]";
    -                LOG.error(message);
    +                if (error.equals(KafkaError.NOT_LEADER_FOR_PARTITION)) {
    --- End diff --
    
    I see. Then we can remove this log itself since the same message is being logged again at https://github.com/apache/storm/blob/master/external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaSpout.java#L143. 
    TridentKafkaSpout is swallowing up the exception. You can add the exception in the log there. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the pull request:

    https://github.com/apache/storm/pull/1381#issuecomment-215688879
  
    Looks like a flaky test. Going to try again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

Posted by srdo <gi...@git.apache.org>.
GitHub user srdo reopened a pull request:

    https://github.com/apache/storm/pull/1381

    STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log to warn from error

    This error is transient most of the time and will occur during normal operation. Downgrading it to warning makes the error log much less noisy.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-1746

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1381
    
----
commit 7e5b9c50c54dba43e2cac1b5f0ad3c7eb001d060
Author: Stig Rohde Døssing <sd...@it-minds.dk>
Date:   2016-04-29T09:20:32Z

    STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log to warn from error

commit 8307a860629f6cbbfe10c0401143180d7a9a06d0
Author: Stig Rohde Døssing <sd...@it-minds.dk>
Date:   2016-04-29T10:34:18Z

    STORM-1746: Remove duplicate log from KafkaUtils, add FailedFetchException to TridentKafkaEmitter log

commit 4df0abbf34d5260bf3db8835e4749a9578641683
Author: Stig Rohde Døssing <sd...@it-minds.dk>
Date:   2016-04-29T11:02:34Z

    STORM-1746: Error log when the fetch error is not NOT_LEADER_FOR_PARTITION

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the pull request:

    https://github.com/apache/storm/pull/1381#issuecomment-215683426
  
    This has the effect of downgrading all errors from fetch to warning level. Maybe the error log in KafkaUtils should be added back with a check for whether it's NOT_LEADER_FOR_PARTITION?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1381: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log...

Posted by srdo <gi...@git.apache.org>.
GitHub user srdo reopened a pull request:

    https://github.com/apache/storm/pull/1381

    STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log to warn from error

    This error is transient most of the time and will occur during normal operation. Downgrading it to warning makes the error log much less noisy.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-1746

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1381
    
----
commit 7e5b9c50c54dba43e2cac1b5f0ad3c7eb001d060
Author: Stig Rohde D�ssing <sd...@it-minds.dk>
Date:   2016-04-29T09:20:32Z

    STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log to warn from error

commit 8307a860629f6cbbfe10c0401143180d7a9a06d0
Author: Stig Rohde D�ssing <sd...@it-minds.dk>
Date:   2016-04-29T10:34:18Z

    STORM-1746: Remove duplicate log from KafkaUtils, add FailedFetchException to TridentKafkaEmitter log

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1381: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log...

Posted by srdo <gi...@git.apache.org>.
Github user srdo closed the pull request at:

    https://github.com/apache/storm/pull/1381


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1381: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log to war...

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/1381
  
    Closing since it seems like this is a fairly irrelevant change to what is now legacy code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

Posted by srdo <gi...@git.apache.org>.
Github user srdo closed the pull request at:

    https://github.com/apache/storm/pull/1381


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1381: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION log...

Posted by srdo <gi...@git.apache.org>.
Github user srdo closed the pull request at:

    https://github.com/apache/storm/pull/1381


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1381#discussion_r61552972
  
    --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaUtils.java ---
    @@ -213,7 +213,11 @@ public static ByteBufferMessageSet fetchMessages(KafkaConfig config, SimpleConsu
                     throw new TopicOffsetOutOfRangeException(msg);
                 } else {
                     String message = "Error fetching data from [" + partition + "] for topic [" + topic + "]: [" + error + "]";
    -                LOG.error(message);
    +                if (error.equals(KafkaError.NOT_LEADER_FOR_PARTITION)) {
    --- End diff --
    
    Worker gets killed due to this error. It should be logged as error only. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1381#discussion_r61555375
  
    --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaUtils.java ---
    @@ -213,7 +213,11 @@ public static ByteBufferMessageSet fetchMessages(KafkaConfig config, SimpleConsu
                     throw new TopicOffsetOutOfRangeException(msg);
                 } else {
                     String message = "Error fetching data from [" + partition + "] for topic [" + topic + "]: [" + error + "]";
    -                LOG.error(message);
    +                if (error.equals(KafkaError.NOT_LEADER_FOR_PARTITION)) {
    --- End diff --
    
    It should get caught here https://github.com/apache/storm/blob/master/external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaSpout.java#L142 or here https://github.com/apache/storm/blob/master/external/storm-kafka/src/jvm/org/apache/storm/kafka/trident/TridentKafkaEmitter.java#L78


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1381#discussion_r61565774
  
    --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaUtils.java ---
    @@ -213,7 +213,9 @@ public static ByteBufferMessageSet fetchMessages(KafkaConfig config, SimpleConsu
                     throw new TopicOffsetOutOfRangeException(msg);
                 } else {
                     String message = "Error fetching data from [" + partition + "] for topic [" + topic + "]: [" + error + "]";
    -                LOG.error(message);
    +                if (!error.equals(KafkaError.NOT_LEADER_FOR_PARTITION)) {
    --- End diff --
    
    Okay, will do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1746: Downgrade NOT_LEADER_FOR_PARTITION...

Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1381#discussion_r61565123
  
    --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaUtils.java ---
    @@ -213,7 +213,9 @@ public static ByteBufferMessageSet fetchMessages(KafkaConfig config, SimpleConsu
                     throw new TopicOffsetOutOfRangeException(msg);
                 } else {
                     String message = "Error fetching data from [" + partition + "] for topic [" + topic + "]: [" + error + "]";
    -                LOG.error(message);
    +                if (!error.equals(KafkaError.NOT_LEADER_FOR_PARTITION)) {
    --- End diff --
    
    I would still suggest to remove this log completely since we are refreshing for all such errors and a warning with the exception should suffice. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---